Fix dart SDK not uploading correct length of chunks #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chunk length is supposed to be equal to CHUNK_SIZE or whatever is left for the file, but the - 1 for the end made the chunk 1 less than the correct length (due to the way getRange works).
2 tasks
lohanidamodar
approved these changes
Sep 25, 2023
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The chunk length is supposed to be equal to CHUNK_SIZE or whatever is left for the file, but the - 1 for the end made the chunk 1 less than the correct length (due to the way getRange works).
For example, see the chunk length when using fromBytes():
vs fromPath():
Test Plan
Manually tested and was able to upload the file successfully:
In addition, comparing the uploaded file with the original file showed they were the same:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes