Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix between query output #740

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Fix between query output #740

merged 4 commits into from
Nov 12, 2023

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Nov 9, 2023

What does this PR do?

  • Fix between serialization. Parsing was changed to handle between like between("attr", 1, 10) but SDKs still output them as between("attr", [1,10])

Test Plan

Existing tests

Related PRs and Issues

appwrite/appwrite#5650

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@abnegate abnegate changed the base branch from master to 1.5.x November 10, 2023 00:18
@abnegate abnegate changed the base branch from 1.5.x to master November 10, 2023 00:19
@lohanidamodar lohanidamodar merged commit 4c431d5 into master Nov 12, 2023
36 checks passed
@stnguyen90 stnguyen90 deleted the fix-between-serialization branch November 22, 2023 23:28
This was referenced Dec 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohanidamodar lohanidamodar lohanidamodar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abnegate @lohanidamodar