Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deno): add sync with meilisearch template #212

Merged
merged 5 commits into from
Oct 12, 2023
Merged

feat(deno): add sync with meilisearch template #212

merged 5 commits into from
Oct 12, 2023

Conversation

Aunali321
Copy link
Contributor

closes #189

@loks0n loks0n assigned loks0n and Aunali321 and unassigned loks0n Oct 3, 2023
@loks0n loks0n self-requested a review October 3, 2023 08:49
loks0n
loks0n requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please can you provide a test video as outlined in #189

loks0n
loks0n requested changes Oct 3, 2023
View reviewed changes
deno/sync-with-meilisearch/src/main.js Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/env.d.ts Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/main.js Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/utils.js Outdated Show resolved Hide resolved
@Aunali321
Copy link
Contributor Author

Thanks for the contribution!

Please can you provide a test video as outlined in #189

Completely missed that! sorry. i have some local push changes to push to complete all requested changes but i am having trouble setting up self hosted instance to test (Cloud doesn't offer Deno runtime yet.) i will keep you updated.

@Aunali321
Copy link
Contributor Author

Almost done with the PR. Have a minor issue where i can run it fine locally and on deno playground but not on appwrite with the same settings.

stnguyen90
stnguyen90 requested changes Oct 5, 2023
View reviewed changes
deno/sync-with-meilisearch/src/main.ts Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/main.ts Outdated Show resolved Hide resolved
loks0n
loks0n requested changes Oct 6, 2023
View reviewed changes
deno/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/main.ts Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/main.ts Outdated Show resolved Hide resolved
@loks0n
Copy link
Member

loks0n commented Oct 6, 2023 •
edited
Loading

Code looks awesome 😎 Just waiting on test video.
If you still having issues setting up deno runtime on your local instance please join our discord and our awesome community should be able to support!

@Aunali321
Copy link
Contributor Author

Here it is!. sorry for laggy video, it was running on vm. and thanks for coping with me!
appwrite-hackthon-proof.webm

@Aunali321 Aunali321 requested a review from loks0n October 9, 2023 19:13
@stnguyen90 stnguyen90 requested review from stnguyen90 and removed request for stnguyen90 October 10, 2023 22:27
stnguyen90
stnguyen90 requested changes Oct 10, 2023
View reviewed changes
deno/sync-with-meilisearch/README.md Outdated Show resolved Hide resolved
loks0n
loks0n requested changes Oct 11, 2023
View reviewed changes
deno/sync-with-meilisearch/README.md Outdated Show resolved Hide resolved
deno/sync-with-meilisearch/src/main.ts Show resolved Hide resolved
deno/sync-with-meilisearch/src/utils.ts Show resolved Hide resolved
@Aunali321
Copy link
Contributor Author

Can this be merged?

@loks0n loks0n merged commit 954c0c0 into appwrite:main Oct 12, 2023
@Aunali321 Aunali321 deleted the feat/add-meilisearch-for-deno branch October 12, 2023 15:41
This was referenced Nov 1, 2023
Closed
Closed
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n loks0n approved these changes

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees

@Aunali321 Aunali321

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Sync with Meilisearch for Deno
4 participants
@Aunali321 @loks0n @gewenyu99 @stnguyen90