doc: Added await to cookies().get() promise
#1365
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-09-19 15:28:51 CET |
loks0n
reviewed
Oct 7, 2024
| @@ -20,7 +20,7 @@ export async function createSessionClient() { | |||
| .setEndpoint(process.env.NEXT_PUBLIC_APPWRITE_ENDPOINT) | |||
| .setProject(process.env.NEXT_PUBLIC_APPWRITE_PROJECT); | |||
|
|
|||
| const session = cookies().get("my-custom-session"); | |||
| const session = await cookies().get("my-custom-session"); | |||
There was a problem hiding this comment.
Should it be (await cookies()).get("my-custom-session"); ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cookies().get()is an asynchronous function. Addingawaitto the sample code ensures that the cookie is read prior to moving to the next instructions. Not handling this as a promise makes it prone for the code to not run as intended and hard to debug.Test Plan
Not needed, sample code just follows the standards https://wicg.github.io/cookie-store/#CookieStore-get
Related PRs and Issues
Fixes #1364
Have you read the Contributing Guidelines on issues?
Yes