Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add vale #192

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

WIP: feat: add vale #192

wants to merge 10 commits into from

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Oct 4, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 3:47pm

@loks0n loks0n marked this pull request as draft October 4, 2023 13:22
@loks0n loks0n changed the title feat: add vale WIP: feat: add vale Oct 4, 2023
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of things this can't do for sentence cases.

You already addressed the sentence case starting with numbers, but also proper nouns in sentence case is not enforced well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants