-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed z-index of mobile header to 120. #259
Changed z-index of mobile header to 120. #259
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @shashankdaima, I think there is no reason to jump to such a big If you want, you can decrease it as well on Thanks so much :-) |
Thanks elad, The reason to jump up to 999 is because main-header has that value. I was not sure about z-index of any other components. I consider it to be standard. Will change that to 120. |
@elad2412 you can now check that out here. |
@shashankdaima, thanks for raising this PR! Especially during Hacktoberfest, we ask that people wait until they are assigned on an issue before working on it. This makes it fair for multiple people who want to work on an issue. Since someone else asked to work on this issue before you, I'll have to give them priority on it. If they don't work on it, we may be able to merge your PR. Please make sure to comment on the issue asking to be assigned. For reference, see our Hacktoberfest guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
@TGlide is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
What does this PR do?
Minor UI fix, the zindex of mobile appbar was 20 instead of 999. Due to this, appbar opacity loses at a particular position.
Test Plan
No, need of any particular test according to me. Feel free to comment if anyone thinks of any test. Regarding this.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes