Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed z-index of mobile header to 120. #259

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

shashankdaima
Copy link
Contributor

@shashankdaima shashankdaima commented Oct 18, 2023

What does this PR do?

Minor UI fix, the zindex of mobile appbar was 20 instead of 999. Due to this, appbar opacity loses at a particular position.
image

Test Plan

No, need of any particular test according to me. Feel free to comment if anyone thinks of any test. Regarding this.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 0:29am

@elad2412
Copy link
Contributor

Hi @shashankdaima, I think there is no reason to jump to such a big z-index, please change it to 120, and we will merge it.

If you want, you can decrease it as well on _main-header.scss to 120.

Thanks so much :-)

@shashankdaima
Copy link
Contributor Author

Thanks elad, The reason to jump up to 999 is because main-header has that value. I was not sure about z-index of any other components. I consider it to be standard. Will change that to 120.
Well, thanks for reviewing it.

@shashankdaima
Copy link
Contributor Author

@elad2412 you can now check that out here.

@shashankdaima shashankdaima changed the title Changed z-index of mobile header to 999. Changed z-index of mobile header to 120. Oct 18, 2023
@stnguyen90
Copy link
Contributor

stnguyen90 commented Oct 18, 2023

@shashankdaima, thanks for raising this PR! Especially during Hacktoberfest, we ask that people wait until they are assigned on an issue before working on it. This makes it fair for multiple people who want to work on an issue. Since someone else asked to work on this issue before you, I'll have to give them priority on it. If they don't work on it, we may be able to merge your PR. Please make sure to comment on the issue asking to be assigned.

For reference, see our Hacktoberfest guidelines.

Copy link
Contributor

@elad2412 elad2412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

Copy link

vercel bot commented Dec 18, 2023

@TGlide is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@TGlide TGlide merged commit 93af7af into appwrite:main Dec 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants