feat: nav tooltips #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
reviewed
Sep 20, 2023
There was a problem hiding this comment.
When collapsed the title is still visible
On Chrome Linux the hover state is not correct
When I click on the button to expand the navbar the titles appear before it's expanded
Screencast from 2023-09-20 19-57-40.webm
The tooltip is visible even when the navbar is at full width. Is that intentional? (When we expand it by clicking the button the tooltip is not visible)
(this is probably for the design team )Right side navigation links don't have a hover state
|
So the rest is for a different task, but it should not show the tooltip when open 👀 what browser did you use? |
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.