Skip to content

Commit

Permalink
ci: run on pr updates from main branch (#30)
Browse files Browse the repository at this point in the history
With `pull_request`, we run in the context of the pull request branch.

- This means we run with the code from the PR branch, possibly breaking
  the current release PR for this repo with in-progress, unreviewed changes.
- This means that the secret is not available on Pull Requests from
  forks.

Switching to `pull_request_target` means we always run in the scope of
the original repository. The secret is available and the code is checked
out from our main branch.

`pull_request_target` has security considerations, but they do not apply
here as we do not check out or run code from the (external, malicious) PR.
  • Loading branch information
apricote authored Aug 25, 2024
1 parent 2cd73a8 commit 2567f0a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/releaser-pleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: releaser-pleaser
on:
push:
branches: [main]
# TODO: use pull_request_target to avoid tainting the actual release PR with code from open feature pull requests
pull_request:
# Using pull_request_target to avoid tainting the actual release PR with code from open feature pull requests
pull_request_target:
types:
- edited
- labeled
Expand All @@ -14,10 +14,13 @@ permissions: {}

jobs:
releaser-pleaser:
# TODO: if: push or pull_request.closed
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: main

- name: Set up Go
uses: actions/setup-go@v5
Expand Down

0 comments on commit 2567f0a

Please sign in to comment.