Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): show release PR url in log messages #44

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(cli): show release PR url in log messages #44

merged 1 commit into from
Sep 6, 2024

Conversation

apricote
Copy link
Owner

@apricote apricote commented Sep 6, 2024

Makes navigating to the PR way easier when looking at the logs.

This requires a new Forge.PullRequestURL() method that needs to be implemented for all forges.

Makes navigating to the PR way easier when looking at the logs.

This requires a new `Forge.PullRequestURL()` method that needs to be
implemented for all forges.
@apricote apricote self-assigned this Sep 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.22%. Comparing base (2effe5e) to head (e993d4a).

Files with missing lines Patch % Lines
internal/forge/github/github.go 0.00% 2 Missing ⚠️
releaserpleaser.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   27.27%   27.22%   -0.06%     
==========================================
  Files          21       21              
  Lines        1078     1080       +2     
==========================================
  Hits          294      294              
- Misses        766      768       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote marked this pull request as ready for review September 6, 2024 21:27
@apricote apricote merged commit b9dd0f9 into main Sep 6, 2024
3 checks passed
@apricote apricote deleted the pr-url branch September 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants