Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull info from app build.gradle if available #3

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

chris-griffin
Copy link

@chris-griffin chris-griffin commented Jun 25, 2019

Fixes android build errors on newer android API versions Task :react-native-os:verifyReleaseResources FAILED

  • Pulls build.gradle vars like compileSdkVersion from the parent app if available

@phillbaker phillbaker merged commit 31b8a18 into aprock:master Jun 25, 2019
@chris-griffin chris-griffin changed the title Pull info from app build.gradle if available; Use implementation Pull info from app build.gradle if available Jun 25, 2019
@chris-griffin chris-griffin mentioned this pull request Jun 25, 2019
phillbaker pushed a commit that referenced this pull request Jun 25, 2019
phillbaker added a commit that referenced this pull request Jun 25, 2019
@phillbaker
Copy link
Collaborator

Released in react-native-os@1.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants