Make database open attempts configurable also via config file

aptly-dev · Aug 21, 2019 · 6f9b268 · 6f9b268
1 parent 77d7c38
commit 6f9b268
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 3 deletions.
diff --git a/context/context.go b/context/context.go
@@ -259,7 +259,13 @@ func (context *AptlyContext) _database() (database.Storage, error) {
 		}
 	}
 
-	tries := context.flags.Lookup("db-open-attempts").Value.Get().(int)
+	var tries int
+	if context.config().DatabaseOpenAttempts == -1 {
+		tries = context.flags.Lookup("db-open-attempts").Value.Get().(int)
+	} else {
+		tries = context.config().DatabaseOpenAttempts
+	}
+
 	const BaseDelay = 10 * time.Second
 	const Jitter = 1 * time.Second
 

diff --git a/man/aptly.1 b/man/aptly.1
@@ -40,6 +40,7 @@ Configuration file is stored in JSON format (default values shown below):
   "downloadSpeedLimit": 0,
   "downloadRetries": 0,
   "architectures": [],
+  "databaseOpenAttempts": 10,
   "dependencyFollowSuggests": false,
   "dependencyFollowRecommends": false,
   "dependencyFollowAllVariants": false,
@@ -122,6 +123,10 @@ limit in kbytes/sec on download speed while mirroring remote repositories
 number of retries for download attempts
 .
 .TP
+\fBdatabaseOpenAttempts\fR
+number of attempts to open DB if it's locked by other instance; could be overridden with option \fB\-db-open-attempts\fR
+.
+.TP
 \fBarchitectures\fR
 is a list of architectures to process; if left empty defaults to all available architectures; could be overridden with option \fB\-architectures\fR
 .

diff --git a/man/aptly.1.ronn.tmpl b/man/aptly.1.ronn.tmpl
@@ -31,6 +31,7 @@ Configuration file is stored in JSON format (default values shown below):
       "downloadConcurrency": 4,
       "downloadSpeedLimit": 0,
       "downloadRetries": 0,
+      "databaseOpenAttempts": 10,
       "architectures": [],
       "dependencyFollowSuggests": false,
       "dependencyFollowRecommends": false,
@@ -105,6 +106,10 @@ Options:
   * `downloadRetries`:
     number of retries for download attempts
 
+  * `databaseOpenAttempts`:
+    number of attempts to open DB if it's locked by other instance; could be overridden with option
+    `-db-open-attempts`
+
   * `architectures`:
     is a list of architectures to process; if left empty defaults to all available architectures; could be
     overridden with option `-architectures`

diff --git a/system/lib.py b/system/lib.py
@@ -99,6 +99,7 @@ class BaseTest(object):
         "downloadConcurrency": 4,
         "downloadSpeedLimit": 0,
         "downloadRetries": 5,
+        "databaseOpenAttempts": 10,
         "architectures": [],
         "dependencyFollowSuggests": False,
         "dependencyFollowRecommends": False,

diff --git a/system/t02_config/ConfigShowTest_gold b/system/t02_config/ConfigShowTest_gold
@@ -3,6 +3,7 @@
     "downloadConcurrency": 4,
     "downloadSpeedLimit": 0,
     "downloadRetries": 5,
+    "databaseOpenAttempts": 10,
     "architectures": [],
     "dependencyFollowSuggests": false,
     "dependencyFollowRecommends": false,

diff --git a/system/t02_config/CreateConfigTest_gold b/system/t02_config/CreateConfigTest_gold
@@ -3,6 +3,7 @@
   "downloadConcurrency": 4,
   "downloadSpeedLimit": 0,
   "downloadRetries": 0,
+  "databaseOpenAttempts": 10,
   "architectures": [],
   "dependencyFollowSuggests": false,
   "dependencyFollowRecommends": false,
@@ -20,4 +21,4 @@
   "FileSystemPublishEndpoints": {},
   "S3PublishEndpoints": {},
   "SwiftPublishEndpoints": {}
-}
+}
diff --git a/system/t02_config/aptly.conf b/system/t02_config/aptly.conf
@@ -1,10 +1,11 @@
 {
   "rootDir": "/tmp/aptly",
   "downloadConcurrency": 4,
+  "databaseOpenAttempts": 10,
   "architectures": [],
   "dependencyFollowSuggests": false,
   "dependencyFollowRecommends": false,
   "dependencyFollowAllVariants": false,
   "gpgDisableSign": false,
   "gpgDisableVerify": false
-}
+}
diff --git a/utils/config.go b/utils/config.go
@@ -12,6 +12,7 @@ type ConfigStructure struct { // nolint: maligned
 	DownloadConcurrency    int                              `json:"downloadConcurrency"`
 	DownloadLimit          int64                            `json:"downloadSpeedLimit"`
 	DownloadRetries        int                              `json:"downloadRetries"`
+	DatabaseOpenAttempts   int                              `json:"databaseOpenAttempts"`
 	Architectures          []string                         `json:"architectures"`
 	DepFollowSuggests      bool                             `json:"dependencyFollowSuggests"`
 	DepFollowRecommends    bool                             `json:"dependencyFollowRecommends"`
@@ -76,6 +77,7 @@ var Config = ConfigStructure{
 	RootDir:                filepath.Join(os.Getenv("HOME"), ".aptly"),
 	DownloadConcurrency:    4,
 	DownloadLimit:          0,
+	DatabaseOpenAttempts:   -1,
 	Architectures:          []string{},
 	DepFollowSuggests:      false,
 	DepFollowRecommends:    false,

diff --git a/utils/config_test.go b/utils/config_test.go
@@ -58,6 +58,7 @@ func (s *ConfigSuite) TestSaveConfig(c *C) {
 		"  \"downloadConcurrency\": 5,\n"+
 		"  \"downloadSpeedLimit\": 0,\n"+
 		"  \"downloadRetries\": 0,\n"+
+		"  \"databaseOpenAttempts\": 10,\n"+
 		"  \"architectures\": null,\n"+
 		"  \"dependencyFollowSuggests\": false,\n"+
 		"  \"dependencyFollowRecommends\": false,\n"+