Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish releases and nightly builds from ci #1055

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

randombenj
Copy link
Contributor

Description of the Change

#920

We moved the whole aptly infrastructure to our own infrastructure and moved internal.aptly.info to aptly-ops.aptly.info
so we can publish new releases there. 🎉

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@randombenj randombenj requested review from ximon18 and neolynx April 4, 2022 14:55
Copy link
Contributor

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the infrastructure that will host the release or how that works but the changes in this PR seen fairly minimal and self-evident.

The only concern I can think of is that it seems that the same credentials are used for publishing both master nightly and tagged release artefacts and if there is somewhere in the nightly setup a weakness through which the credentials could be obtained then the damage would not be limited to nightly builds but could also be used to compromise actual releases.

@randombenj
Copy link
Contributor Author

@ximon18 Thanks for the review. Yeah thats a fair point, however, I will keep the setup as is for now as it was like this before as well. I think this can still be improved later on.

@randombenj randombenj merged commit 47bda05 into master Apr 4, 2022
@neolynx neolynx deleted the change-release-publish-point branch July 3, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants