Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: support disabling ACL with none value #1087

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

wadey
Copy link
Contributor

@wadey wadey commented Jun 22, 2022

This change lets you disable ACL when using S3 by using a configuration
value of none. This way we maintain backward compatibility with the
default setting being private.

Fixes: #1067

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

This change lets you disable ACL when using S3 by using a configuration
value of `none`. This way we maintain backward compatibility with the
default setting being `private`.

Fixes: aptly-dev#1067
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1087 (461e3ff) into master (2aca913) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
- Coverage   52.15%   52.13%   -0.02%     
==========================================
  Files          73       73              
  Lines       11257    11259       +2     
==========================================
- Hits         5871     5870       -1     
- Misses       4822     4824       +2     
- Partials      564      565       +1     
Impacted Files Coverage Δ
s3/public.go 56.68% <0.00%> (-0.63%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@randombenj randombenj merged commit c9f5763 into aptly-dev:master Jun 22, 2022
@randombenj randombenj added this to the 1.5.0 milestone Jun 23, 2022
@wadey
Copy link
Contributor Author

wadey commented Jun 30, 2022

@randombenj how do I get the docs updated here now that 1.5.0 has been released?

Is there a docs repo to submit a PR to?

@wadey wadey deleted the acl-none branch June 30, 2022 16:09
wadey added a commit to wadey/www.aptly.info that referenced this pull request Jun 30, 2022
This new configuration value was added in 1.5.0 with this PR:

- aptly-dev/aptly#1087
@wadey
Copy link
Contributor Author

wadey commented Jun 30, 2022

@randombenj ah I found it, PR opened:

@AirOne70
Copy link

AirOne70 commented Mar 1, 2023

This fix is not working on my side. I had to use " " instead of "none" to make it working.
From what I can see with Debug enabled "X-Amz-Acl: none" is set but S3 answer is "HTTP/1.1 400 Bad Request".

@wadey
Copy link
Contributor Author

wadey commented Mar 1, 2023

@AirOne70 are you sure you are running aptly version 1.5 or newer? Can you check your version?

@AirOne70
Copy link

AirOne70 commented Mar 1, 2023

@wadey Thanks for your answer. You're right, I updated Aptly only few days before the 1.5 release. That explains it. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aptly does not support publishing objects without ACL rules
3 participants