Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -skip-cleanup option for publish commands. #620

Merged
merged 4 commits into from
Sep 26, 2017

Conversation

cavedon
Copy link
Contributor

@cavedon cavedon commented Aug 16, 2017

Fixes #570.

Description of the Change

When publishing multiple large snapshot (e.g. Ubuntu security snapshots) under the same prefix aptly becames very slow when switching and dropping publishes in that prefix, and the slow part is the "Cleaning up prefix "[...]" components main...".

In case of it is necessary to update/switch/drop multiple published repos/snapshots, a significant amount of time can be saved by performing the cleanup phase only after the last one operation.

This change allow skipping the cleanup of unreferenced files on publish switch/update/drop via the -skip-cleanup command line option. It also adds support for the API SkipCleanup parameter.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Allow skipping unreferenced files cleanup on publish switch/update/drop
via the -skip-cleanup command line option.
Also support API SkipCleanup parameter.

Fixes aptly-dev#570.
@smira
Copy link
Contributor

smira commented Aug 16, 2017

Thanks!

@cavedon
Copy link
Contributor Author

cavedon commented Aug 16, 2017

Thank you for considering this change for merge!
I have used the web UI to resolve the conflict on AUTHORS.

@smira smira added the feature label Sep 26, 2017
@smira smira merged commit d611d0d into aptly-dev:master Sep 26, 2017
smira referenced this pull request in smira/aptly-dev.github.io Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to skip prefix cleanup on publish operations
2 participants