Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deb reader handle new control.tar options introduced in dpkg 1.17.6 #658

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

hsitter
Copy link
Contributor

@hsitter hsitter commented Oct 31, 2017

newly supported is uncompressed control.tar and xz compressed
control.tar.xz. latter is used by ubuntu for dbgsym ddebs.

Fixes #655

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Currently Ubuntu 18.04 builds with ddebs (debug symbols) cannot be uploaded to aptly as they get rejected with

    Unable to read file /home/me/.aptly/upload/Aptly__Repository-smith-20171031-18307-yjnsbr/test.ddeb: unable to find control.tar.gz part in package /home/me/.aptly/upload/Aptly__Repository-smith-20171031-18307-yjnsbr/test.ddeb

which is caused by the packages making use of control.tar.xz members which are fairly newly supported in dpkg. The proposed change adds support for new control.tar variants as per deb format specification manpage.

Checklist

  • unit-test added (if change is algorithm)

@hsitter
Copy link
Contributor Author

hsitter commented Oct 31, 2017

Travis seems to fall over gometalinter, not sure why or what to do about that.

@hsitter hsitter force-pushed the control-tar-xz-support branch from d75647e to bd3eab9 Compare October 31, 2017 11:09
@hsitter
Copy link
Contributor Author

hsitter commented Oct 31, 2017

Linting fixed by #659

newly supported is uncompressed control.tar and xz compressed
control.tar.xz. latter is used by ubuntu for dbgsym ddebs.

Fixes aptly-dev#655
@hsitter hsitter force-pushed the control-tar-xz-support branch from bd3eab9 to 1885cbd Compare October 31, 2017 13:43
@hsitter
Copy link
Contributor Author

hsitter commented Oct 31, 2017

rebased & travis green now

@smira smira added the 1.2.0 label Nov 1, 2017
Copy link
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for awesome PR!

@smira smira merged commit 67c2636 into aptly-dev:master Nov 1, 2017
@NeroBurner NeroBurner mentioned this pull request Apr 4, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants