properly expose AcquireByHash through the api #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new publish calls can now enable AcquireByHash by right away (previously one would have had to create a new publishing endpoint and then explicitly switch it to AcquireByHash) - all json marshals of PublishedRepo now contain AcquireByHash (allows inspecting if a given endpoint has AcquireByHash enabled already; also enables verification that a switch/update actually applied a potential AcquireByHash change - update all tests to reflect that default state of AcquireByHash - update creation and switch testing to explicitly toggle AcquireByHash to make sure state mutation works as expected
|
I am not quite sure why that test fails. it seems fairly unrelated -.- |
|
#698 fixes the failing test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one would have had to create a new publishing endpoint and then
explicitly switch it to AcquireByHash)
inspecting if a given endpoint has AcquireByHash enabled already; also
enables verification that a switch/update actually applied a
potential AcquireByHash change
make sure state mutation works as expected
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
AcquireByHash is rubbish to use via API without this.
Checklist
AUTHORS