Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose repo include through API #751

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Conversation

sliverc
Copy link
Contributor

@sliverc sliverc commented Jun 18, 2018

Description of the Change

Expose repo include through API.

See aptly-dev/www.aptly.info#72 for documentation.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #751 into master will increase coverage by 1.45%.
The diff coverage is 61.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   59.19%   60.64%   +1.45%     
==========================================
  Files          50       50              
  Lines        6190     6276      +86     
==========================================
+ Hits         3664     3806     +142     
+ Misses       2125     2033      -92     
- Partials      401      437      +36
Impacted Files Coverage Δ
deb/deb.go 60.83% <ø> (ø) ⬆️
deb/changes.go 59.74% <61.36%> (+20.42%) ⬆️
deb/import.go 44.52% <0%> (+44.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e446e...9509629. Read the comment docs.

@sliverc sliverc force-pushed the repo_include_api branch from 7a7cd76 to bcd747c Compare June 18, 2018 15:19
@smira smira added this to the 1.4.0 milestone Jun 18, 2018
@smira
Copy link
Contributor

smira commented Jun 18, 2018

I've added milestone link so that it's easier to compile release notes :)

@aviau
Copy link
Contributor

aviau commented Jun 19, 2018

Woah, what a great timing.

I am currently looking for a repository management tool for https://auto.debian.net/ (which is also written in Go btw).

I'd love to see this merged. If I understand, this is what I need to create repositories and add packages via the rest API?

From what I can see the API cannot currently do that. I'd love to be one of the first users and provide feedback, if you are interested.

@sliverc sliverc force-pushed the repo_include_api branch 2 times, most recently from 2b0e3c9 to b61d48c Compare June 19, 2018 11:01
@sliverc sliverc added the 1.4.0 label Jun 19, 2018
@sliverc sliverc force-pushed the repo_include_api branch from b61d48c to b5d1f6d Compare June 19, 2018 12:34
@sliverc sliverc force-pushed the repo_include_api branch from b5d1f6d to 9509629 Compare June 19, 2018 13:40
@sliverc
Copy link
Contributor Author

sliverc commented Jun 19, 2018

@aviau Aptly already has support to create local repositories through API (https://www.aptly.info/doc/api/repos/). This PR is simply expanding the API to support .changes files as well.

If you have other questions feel free to contact us on aptly-discuss

@sliverc sliverc merged commit d1a2842 into aptly-dev:master Jun 19, 2018
@sliverc sliverc deleted the repo_include_api branch June 19, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants