Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go modules instead of dep #880

Merged
merged 2 commits into from
Sep 27, 2019

Conversation

smira
Copy link
Contributor

@smira smira commented Sep 26, 2019

As minimum support Go version for aptly is 1.11, we can start using Go modules.

This makes repo much more slim (no vendor/ directory), and provides better support going forward to use mainstream dependency management.

@smira smira force-pushed the go-modules-experiment branch from 17ecc7e to a708258 Compare September 26, 2019 22:11
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files          54       54           
  Lines        6673     6673           
=======================================
  Hits         4257     4257           
  Misses       1890     1890           
  Partials      526      526

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b731e17...ba85d9a. Read the comment docs.

@smira
Copy link
Contributor Author

smira commented Sep 26, 2019

Fails due to #881

@smira smira added this to the 1.5.0 milestone Sep 26, 2019
@smira smira changed the title Go modules experiment Switch to Go modules instead of dep Sep 27, 2019
@smira smira force-pushed the go-modules-experiment branch from a708258 to 6c488d4 Compare September 27, 2019 10:02
@smira smira force-pushed the go-modules-experiment branch from 6c488d4 to ba85d9a Compare September 27, 2019 10:43
@smira smira merged commit 19db62d into aptly-dev:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant