Fix tests #937
Merged
Fix tests #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it's possible that certain network configuration defining *.localhost cause the tests to fail.
Even if a simple git hash.
PGP tests relied on expired gpg keys: upgrade with newer Debian keys from https://ftp-master.debian.org/keys.html. Download new fixtures files from http://ftp.debian.org/debian/dists/buster/
|
Interesting, normal Travis tests pass but the ones triggered by a PR do not. |
szakalboss
approved these changes
Feb 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 63.79% 61.41% -2.39%
==========================================
Files 54 54
Lines 6674 5911 -763
==========================================
- Hits 4258 3630 -628
+ Misses 1890 1757 -133
+ Partials 526 524 -2
Continue to review full report at Codecov.
|
|
Simply re-running the failing Travis job above made it pass. So, the problem must be some race condition or otherwise aleatory condition. I think it makes sense to merge this patch and tackle this other problem in another PR. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
Fix tests failing on Travis.
Most of the tests were failing because of expired PGP keys. I've downloaded the most recent ones from Debian (and elsewhere), updated the fixtures and fixed some more tests.
The patchset is already large as it is. In following PRs I'd like to: