Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replay-verify workflow tunings #10281

Merged
merged 2 commits into from
Sep 28, 2023
Merged

replay-verify workflow tunings #10281

merged 2 commits into from
Sep 28, 2023

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Sep 27, 2023

Description

  1. not reference workflows by @main
  2. not cancel other sub-jobs on first failure

Test Plan

manually scheduled https://github.com/aptos-labs/aptos-core/actions/runs/6341570151?pr=10281

-- sub-job failure didn't cancel other sub-jobs.

@msmouse msmouse requested review from a team as code owners September 27, 2023 22:17
@msmouse msmouse requested review from geekflyer, perryjrandall and a team September 28, 2023 18:37
@msmouse msmouse enabled auto-merge (rebase) September 28, 2023 18:51
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f

Compatibility test results for aptos-node-v1.6.2 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4205 txn/s, latency: 6916 ms, (p50: 6800 ms, p90: 9400 ms, p99: 13200 ms), latency samples: 176620
2. Upgrading first Validator to new version: 28c45e00a7276a5817df1d697db028cc4ec6378f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1846 txn/s, latency: 15800 ms, (p50: 18600 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92300
3. Upgrading rest of first batch to new version: 28c45e00a7276a5817df1d697db028cc4ec6378f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1687 txn/s, latency: 16503 ms, (p50: 17500 ms, p90: 21800 ms, p99: 34500 ms), latency samples: 86040
4. upgrading second batch to new version: 28c45e00a7276a5817df1d697db028cc4ec6378f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3334 txn/s, latency: 9265 ms, (p50: 9900 ms, p90: 12000 ms, p99: 12700 ms), latency samples: 140040
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 28c45e00a7276a5817df1d697db028cc4ec6378f

two traffics test: inner traffic : committed: 6740 txn/s, latency: 5808 ms, (p50: 5400 ms, p90: 7300 ms, p99: 11700 ms), latency samples: 2918540
two traffics test : committed: 100 txn/s, latency: 2418 ms, (p50: 2300 ms, p90: 2800 ms, p99: 10600 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.247, avg: 0.215", "QsPosToProposal: max: 0.153, avg: 0.140", "ConsensusProposalToOrdered: max: 0.600, avg: 0.585", "ConsensusOrderedToCommit: max: 0.450, avg: 0.427", "ConsensusProposalToCommit: max: 1.036, avg: 1.011"]
Max round gap was 1 [limit 4] at version 943983. Max no progress secs was 3.6022801 [limit 10] at version 943983.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f

Compatibility test results for aptos-node-v1.5.1 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f (PR)
Upgrade the nodes to version: 28c45e00a7276a5817df1d697db028cc4ec6378f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4236 txn/s, latency: 4926 ms, (p50: 5000 ms, p90: 8000 ms, p99: 8400 ms), latency samples: 237220
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 28c45e00a7276a5817df1d697db028cc4ec6378f passed
Test Ok

@msmouse msmouse merged commit 89b9842 into aptos-labs:main Sep 28, 2023
139 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants