Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use crazy machines and no VFN #10512

Closed
wants to merge 4 commits into from
Closed

use crazy machines and no VFN #10512

wants to merge 4 commits into from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Oct 14, 2023

Description

Test Plan

@msmouse msmouse added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Oct 17, 2023
@sitalkedia
Copy link
Contributor

@msmouse - You mean to merge this change in previewnet branch and not main right?

@sitalkedia
Copy link
Contributor

Also, seems like this PR contain two unrelated changes - 1. reverting the VM loader stuff and 2. configuration changes for higher TPS. Possible to split it into two commits so that the previewnet branch history remains cleaner?

@msmouse
Copy link
Contributor Author

msmouse commented Oct 24, 2023

@sitalkedia yes this is not mean to be landed on main, just demonstrating what you need to run the forge tests. previewnet2 branch is not cut yet.

@msmouse msmouse closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov georgemitenkov will be requested when the pull request is marked ready for review georgemitenkov is a code owner

Assignees
No one assigned
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msmouse @sitalkedia @runtian-zhou