[fix] make the max supply unlimited #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13913 +/- ##
===========================================
- Coverage 71.9% 59.0% -13.0%
===========================================
Files 2316 822 -1494
Lines 457023 198161 -258862
===========================================
- Hits 328998 117008 -211990
+ Misses 128025 81153 -46872 ☔ View full report in Codecov by Sentry. |
lightmark
force-pushed
the
lightmark/fix_supply
branch
from
f1ea66c to
579821d
Compare
This was referenced Jul 3, 2024
igor-aptos
approved these changes
Jul 3, 2024
movekevin
approved these changes
Jul 9, 2024
| @@ -1011,12 +1011,12 @@ module aptos_framework::fungible_asset { | |||
|
|
|||
| public(friend) fun deposit_internal(store_addr: address, fa: FungibleAsset) acquires FungibleStore, ConcurrentFungibleBalance { | |||
| let FungibleAsset { metadata, amount } = fa; | |||
| if (amount == 0) return; | |||
|
|
|||
| assert!(exists<FungibleStore>(store_addr), error::not_found(EFUNGIBLE_STORE_EXISTENCE)); | |||
There was a problem hiding this comment.
Can you move this to the first line? Line 1013 is only needed for the subsequent metadata check
There was a problem hiding this comment.
This is nit 5 fix...
lightmark
force-pushed
the
lightmark/fix_supply
branch
3 times, most recently
from
57d7a68 to
294be9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lightmark
force-pushed
the
lightmark/fix_supply
branch
from
294be9b to
4ee6962
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
zi0Black
pushed a commit
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coin has unlimited supply, so does FA.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist