Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protobuf] Support validator transaction type in protobuf (#13897) #14019

Merged

Conversation

ying-w
Copy link

@ying-w ying-w commented Jul 16, 2024

  • format and add new transaction type.

  • format + cleanup + new transaciton type.

  • update.

  • fix the validator transaction.

  • upgrade protobuf.

  • grpc support validator transaction.

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

* format and add new transaction type.

* format  + cleanup + new transaciton type.

* update.

* fix the validator transaction.

* upgrade protobuf.

* grpc support validator transaction.
Copy link

trunk-io bot commented Jul 16, 2024

@sherry-x sherry-x enabled auto-merge (squash) July 16, 2024 18:06

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b

Compatibility test results for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b (PR)
1. Check liveness of validators at old version: f648076a280621dbfd4e73b1ca83e3a3f52878ed
compatibility::simple-validator-upgrade::liveness-check : committed: 7613.01303595738 txn/s, latency: 3745.127114081206 ms, (p50: 3000 ms, p90: 4500 ms, p99: 26000 ms), latency samples: 315740
2. Upgrading first Validator to new version: 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7352.811182355304 txn/s, latency: 3626.62989091431 ms, (p50: 4100 ms, p90: 4300 ms, p99: 4400 ms), latency samples: 139340
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6291.7399172872365 txn/s, latency: 4771.562431211499 ms, (p50: 4600 ms, p90: 5600 ms, p99: 8300 ms), latency samples: 243500
3. Upgrading rest of first batch to new version: 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5879.451776784842 txn/s, latency: 4746.3949490513005 ms, (p50: 5400 ms, p90: 5900 ms, p99: 6000 ms), latency samples: 113840
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6096.5415413482 txn/s, latency: 5146.951888159577 ms, (p50: 5000 ms, p90: 7600 ms, p99: 8000 ms), latency samples: 234620
4. upgrading second batch to new version: 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10568.201558744195 txn/s, latency: 2631.029028893293 ms, (p50: 2800 ms, p90: 3200 ms, p99: 3400 ms), latency samples: 191740
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10021.762911052718 txn/s, latency: 3236.1274102135785 ms, (p50: 3100 ms, p90: 4800 ms, p99: 6300 ms), latency samples: 335240
5. check swarm health
Compatibility test for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b

two traffics test: inner traffic : committed: 9500.671742412871 txn/s, latency: 4191.8006718525085 ms, (p50: 4100 ms, p90: 4500 ms, p99: 9900 ms), latency samples: 3612400
two traffics test : committed: 99.96483636059467 txn/s, latency: 2310.1814606741573 ms, (p50: 2100 ms, p90: 3000 ms, p99: 5100 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.255, avg: 0.222", "QsPosToProposal: max: 1.757, avg: 1.568", "ConsensusProposalToOrdered: max: 0.324, avg: 0.289", "ConsensusOrderedToCommit: max: 0.400, avg: 0.386", "ConsensusProposalToCommit: max: 0.690, avg: 0.676"]
Max round gap was 2 [limit 4] at version 4104735. Max no progress secs was 8.27631 [limit 15] at version 4104735.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b

Compatibility test results for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b (PR)
Upgrade the nodes to version: 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1226.7405354920188 txn/s, submitted: 1229.0852230598553 txn/s, failed submission: 2.3446875678364276 txn/s, expired: 2.3446875678364276 txn/s, latency: 2549.976385703364 ms, (p50: 1800 ms, p90: 4600 ms, p99: 9300 ms), latency samples: 104640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1205.4966838130617 txn/s, submitted: 1208.1485555281408 txn/s, failed submission: 2.6518717150791455 txn/s, expired: 2.6518717150791455 txn/s, latency: 2617.4903299725024 ms, (p50: 1800 ms, p90: 4800 ms, p99: 9900 ms), latency samples: 109100
5. check swarm health
Compatibility test for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b passed
Upgrade the remaining nodes to version: 54ffdaa58af65abcc3ac7668a1a4d9cb73ec799b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1132.8801556275935 txn/s, submitted: 1134.8727140408528 txn/s, failed submission: 1.9925584132593983 txn/s, expired: 1.9925584132593983 txn/s, latency: 2817.5633867500487 ms, (p50: 2100 ms, p90: 5100 ms, p99: 10500 ms), latency samples: 102340
Test Ok

@sherry-x sherry-x merged commit 1ce3930 into aptos-release-v1.16 Jul 16, 2024
88 of 94 checks passed
@sherry-x sherry-x deleted the yingw/cherry-pick-validator-transactions branch July 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants