Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mempool] improve parking lot eviction #14586

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[mempool] improve parking lot eviction #14586

merged 1 commit into from
Sep 10, 2024

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Sep 10, 2024 •
edited
Loading

Description

To better handle large transactions

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Sep 10, 2024 •
edited
Loading

⏱️ 3h 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 56m 🟥 🟥 🟩 🟩 
rust-smoke-tests 38m ⬜ 🟩 
forge-framework-upgrade-test / forge 15m 🟩 
forge-compat-test / forge 14m 🟩 
execution-performance / test-target-determinator 14m 🟩 🟩 🟩 
forge-e2e-test / forge 13m 🟩 
test-target-determinator 8m ⬜ ⬜ 🟩 
check 8m ⬜ ⬜ 🟩 
rust-cargo-deny 5m ⬜ 🟩 ⬜ 🟩 
rust-doc-tests 5m 🟩 
general-lints 5m ⬜ 🟩 ⬜ 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 🟩 
rust-doc-tests 3m ⬜ 
rust-move-tests 2m 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩 
rust-move-tests 1m 🟩 
rust-move-tests 1m ⬜ 
file_change_determinator 45s 🟩 🟩 🟩 🟩 
rust-doc-tests 44s ⬜ 
Backport PR 40s 🟥 🟥 🟩 
file_change_determinator 39s 🟩 🟩 🟩 🟩 
file_change_determinator 30s 🟩 🟩 🟩 
rust-move-tests 28s ⬜ 
permission-check 22s 🟩 🟩 🟩 🟩 
permission-check 13s 🟩 🟩 🟩 🟩 
permission-check 10s 🟩 🟩 🟩 🟩 
permission-check 10s 🟩 🟩 🟩 🟩 
permission-check 9s 🟩 🟩 🟩 
permission-check 8s 🟩 🟩 🟩 
determine-docker-build-metadata 5s 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@bchocho bchocho marked this pull request as ready for review September 10, 2024 21:05
@bchocho bchocho added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 10, 2024
@zekun000 zekun000 added the v1.19 label Sep 10, 2024
@bchocho bchocho enabled auto-merge (squash) September 10, 2024 21:10
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c15935cf4f7933b03e8a126258aa5090628de984

two traffics test: inner traffic : committed: 12423.55 txn/s, latency: 3206.74 ms, (p50: 3000 ms, p70: 3300, p90: 3600 ms, p99: 5100 ms), latency samples: 4723720
two traffics test : committed: 99.92 txn/s, latency: 2728.01 ms, (p50: 2600 ms, p70: 2800, p90: 3300 ms, p99: 5300 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.246, avg: 0.229", "QsPosToProposal: max: 0.262, avg: 0.207", "ConsensusProposalToOrdered: max: 0.325, avg: 0.308", "ConsensusOrderedToCommit: max: 0.504, avg: 0.481", "ConsensusProposalToCommit: max: 0.811, avg: 0.789"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.81s no progress at version 2655222 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.52s no progress at version 2655220 (avg 7.52s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984 (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 10414.26 txn/s, latency: 3051.13 ms, (p50: 2100 ms, p70: 2200, p90: 7300 ms, p99: 16000 ms), latency samples: 369800
2. Upgrading first Validator to new version: c15935cf4f7933b03e8a126258aa5090628de984
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6583.08 txn/s, latency: 4173.84 ms, (p50: 4600 ms, p70: 4900, p90: 5300 ms, p99: 5500 ms), latency samples: 121720
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6782.02 txn/s, latency: 4726.11 ms, (p50: 4900 ms, p70: 5100, p90: 6500 ms, p99: 6900 ms), latency samples: 225980
3. Upgrading rest of first batch to new version: c15935cf4f7933b03e8a126258aa5090628de984
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7158.83 txn/s, latency: 3725.19 ms, (p50: 4000 ms, p70: 4500, p90: 4800 ms, p99: 5000 ms), latency samples: 133100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6909.78 txn/s, latency: 4525.36 ms, (p50: 4600 ms, p70: 4900, p90: 6600 ms, p99: 6900 ms), latency samples: 232680
4. upgrading second batch to new version: c15935cf4f7933b03e8a126258aa5090628de984
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11833.71 txn/s, latency: 2263.36 ms, (p50: 2400 ms, p70: 2600, p90: 2700 ms, p99: 3000 ms), latency samples: 205320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6838.43 txn/s, latency: 4812.03 ms, (p50: 2600 ms, p70: 4500, p90: 16300 ms, p99: 17000 ms), latency samples: 283800
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984 (PR)
Upgrade the nodes to version: c15935cf4f7933b03e8a126258aa5090628de984
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1211.23 txn/s, submitted: 1214.75 txn/s, failed submission: 3.52 txn/s, expired: 3.52 txn/s, latency: 2375.27 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5000 ms), latency samples: 110140
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1225.57 txn/s, submitted: 1227.88 txn/s, failed submission: 2.31 txn/s, expired: 2.31 txn/s, latency: 2623.24 ms, (p50: 2400 ms, p70: 2700, p90: 4400 ms, p99: 6000 ms), latency samples: 105960
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c15935cf4f7933b03e8a126258aa5090628de984 passed
Upgrade the remaining nodes to version: c15935cf4f7933b03e8a126258aa5090628de984
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 559.41 txn/s, submitted: 560.14 txn/s, failed submission: 0.74 txn/s, expired: 0.74 txn/s, latency: 6658.66 ms, (p50: 7200 ms, p70: 8000, p90: 8700 ms, p99: 10000 ms), latency samples: 45640
Test Ok

@bchocho bchocho merged commit 847eed2 into main Sep 10, 2024
143 of 192 checks passed
@bchocho bchocho deleted the brian/mempool-fix-parking-lot branch September 10, 2024 22:52
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@bchocho
[mempool] improve parking lot eviction (#14586)
31a24a7 
To better handle large transactions

(cherry picked from commit 847eed2)
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ aptos-release-v1.19

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

bchocho pushed a commit that referenced this pull request Sep 10, 2024
@github-actions
[mempool] improve parking lot eviction (#14586) (#14589)
70806ff
@jlguochn jlguochn mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekun000 zekun000 zekun000 approved these changes

@ibalajiarun ibalajiarun ibalajiarun approved these changes

@sitalkedia sitalkedia Awaiting requested review from sitalkedia

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR v1.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bchocho @ibalajiarun @zekun000