Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use storage ledger version for get txn by hash" #14713

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Sep 20, 2024

not as intended
Reverts #14706

Copy link

trunk-io bot commented Sep 20, 2024

@areshand areshand enabled auto-merge (rebase) September 20, 2024 23:15

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a050fb08cdd41fe93c9e9932c145662cf02bbf0e

two traffics test: inner traffic : committed: 12638.94 txn/s, submitted: 12642.04 txn/s, expired: 3.10 txn/s, latency: 3122.76 ms, (p50: 2700 ms, p70: 3000, p90: 3600 ms, p99: 11500 ms), latency samples: 4805600
two traffics test : committed: 100.12 txn/s, latency: 1662.61 ms, (p50: 1500 ms, p70: 1600, p90: 1800 ms, p99: 6900 ms), latency samples: 1960
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.246, avg: 0.221", "QsPosToProposal: max: 1.195, avg: 1.125", "ConsensusProposalToOrdered: max: 0.324, avg: 0.310", "ConsensusOrderedToCommit: max: 0.420, avg: 0.401", "ConsensusProposalToCommit: max: 0.731, avg: 0.711"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.14s no progress at version 2651832 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.32s no progress at version 2651830 (avg 7.32s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e (PR)
Upgrade the nodes to version: a050fb08cdd41fe93c9e9932c145662cf02bbf0e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1146.25 txn/s, submitted: 1148.07 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2658.25 ms, (p50: 2400 ms, p70: 3000, p90: 4000 ms, p99: 5700 ms), latency samples: 100960
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1078.17 txn/s, submitted: 1080.17 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 2732.85 ms, (p50: 2300 ms, p70: 2800, p90: 4800 ms, p99: 6700 ms), latency samples: 97100
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e passed
Upgrade the remaining nodes to version: a050fb08cdd41fe93c9e9932c145662cf02bbf0e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1227.76 txn/s, submitted: 1231.09 txn/s, failed submission: 3.33 txn/s, expired: 3.33 txn/s, latency: 2458.04 ms, (p50: 2400 ms, p70: 2700, p90: 3500 ms, p99: 5600 ms), latency samples: 110680
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 13068.54 txn/s, latency: 2578.43 ms, (p50: 2100 ms, p70: 2200, p90: 3400 ms, p99: 12000 ms), latency samples: 506040
2. Upgrading first Validator to new version: a050fb08cdd41fe93c9e9932c145662cf02bbf0e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7128.49 txn/s, latency: 3866.56 ms, (p50: 4200 ms, p70: 4400, p90: 5200 ms, p99: 5400 ms), latency samples: 133460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6944.41 txn/s, latency: 4601.75 ms, (p50: 4900 ms, p70: 5400, p90: 6400 ms, p99: 6700 ms), latency samples: 230060
3. Upgrading rest of first batch to new version: a050fb08cdd41fe93c9e9932c145662cf02bbf0e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7121.87 txn/s, latency: 3783.15 ms, (p50: 4100 ms, p70: 4300, p90: 5300 ms, p99: 5400 ms), latency samples: 128720
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7830.29 txn/s, latency: 4071.97 ms, (p50: 4200 ms, p70: 4200, p90: 6300 ms, p99: 6600 ms), latency samples: 259260
4. upgrading second batch to new version: a050fb08cdd41fe93c9e9932c145662cf02bbf0e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4382.47 txn/s, latency: 3179.60 ms, (p50: 3000 ms, p70: 3600, p90: 5300 ms, p99: 8300 ms), latency samples: 155600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9356.28 txn/s, latency: 3223.02 ms, (p50: 2400 ms, p70: 3800, p90: 6200 ms, p99: 8500 ms), latency samples: 316260
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> a050fb08cdd41fe93c9e9932c145662cf02bbf0e passed
Test Ok

@areshand areshand merged commit e87224f into main Sep 21, 2024
88 of 92 checks passed
@areshand areshand deleted the revert-14706-skip_version_check branch September 21, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants