Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CLI 4.2.3. #14731

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Release CLI 4.2.3. #14731

merged 1 commit into from
Sep 24, 2024

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Sep 24, 2024

Description

^

This is to fix the broken indexer at localnet.

How Has This Been Tested?

This was tested in change: #14727

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 24, 2024

⏱️ 3h 53m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-compat-test / forge 53m 🟩🟩🟩
forge-framework-upgrade-test / forge 45m 🟩🟩🟩
forge-e2e-test / forge 42m 🟩🟩🟩
execution-performance / test-target-determinator 18m 🟩🟩🟩🟩
test-target-determinator 12m 🟩🟩🟩
check 11m 🟩🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩🟩
general-lints 7m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-move-tests 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 21m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@larry-aptos larry-aptos marked this pull request as ready for review September 24, 2024 01:05
Copy link
Contributor Author

larry-aptos commented Sep 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @larry-aptos and the rest of your teammates on Graphite Graphite

@larry-aptos larry-aptos enabled auto-merge (squash) September 24, 2024 01:09
@larry-aptos larry-aptos requested a review from a team September 24, 2024 01:09

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably have to update the cargo.lock

@larry-aptos
Copy link
Contributor Author

larry-aptos commented Sep 24, 2024

You probably have to update the cargo.lock

just ran scripts/rust_lint.sh and change looks good

@@ -4,6 +4,9 @@ All notable changes to the Aptos CLI will be captured in this file. This project

## Unreleased

## [4.2.2] - 2024/09/20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.2.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@larry-aptos larry-aptos merged commit 8689b9a into main Sep 24, 2024
47 of 48 checks passed
@larry-aptos larry-aptos deleted the 09-23-release_cli_4.2.3 branch September 24, 2024 09:05
areshand pushed a commit that referenced this pull request Sep 24, 2024
areshand pushed a commit that referenced this pull request Sep 24, 2024
areshand pushed a commit that referenced this pull request Sep 25, 2024
@areshand areshand added CICD:build-performance-images build performance docker image variants CICD:build-images when this label is present github actions will start build+push rust images from the PR. labels Sep 26, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c40c73ea3eed7889ae38aa8a963da6320487936e

two traffics test: inner traffic : committed: 14094.40 txn/s, latency: 2820.92 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 5400 ms), latency samples: 5358960
two traffics test : committed: 100.11 txn/s, latency: 1745.52 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 9700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.228", "QsPosToProposal: max: 1.247, avg: 1.040", "ConsensusProposalToOrdered: max: 0.326, avg: 0.298", "ConsensusOrderedToCommit: max: 0.423, avg: 0.410", "ConsensusProposalToCommit: max: 0.728, avg: 0.708"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.54s no progress at version 39459 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.61s no progress at version 2663095 (avg 8.61s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e (PR)
Upgrade the nodes to version: c40c73ea3eed7889ae38aa8a963da6320487936e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1179.66 txn/s, submitted: 1182.28 txn/s, failed submission: 2.62 txn/s, expired: 2.62 txn/s, latency: 2496.51 ms, (p50: 2400 ms, p70: 2700, p90: 3800 ms, p99: 4900 ms), latency samples: 107980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1169.86 txn/s, submitted: 1172.09 txn/s, failed submission: 2.23 txn/s, expired: 2.23 txn/s, latency: 2559.15 ms, (p50: 2300 ms, p70: 2700, p90: 4200 ms, p99: 6000 ms), latency samples: 104940
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e passed
Upgrade the remaining nodes to version: c40c73ea3eed7889ae38aa8a963da6320487936e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1041.77 txn/s, submitted: 1043.99 txn/s, failed submission: 2.22 txn/s, expired: 2.22 txn/s, latency: 2821.86 ms, (p50: 2400 ms, p70: 3000, p90: 5100 ms, p99: 6900 ms), latency samples: 93700
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e (PR)
1. Check liveness of validators at old version: b6187e1794550f4a6b25cab0e5d40188574241da
compatibility::simple-validator-upgrade::liveness-check : committed: 16846.15 txn/s, latency: 2009.14 ms, (p50: 2100 ms, p70: 2100, p90: 2300 ms, p99: 2600 ms), latency samples: 545880
2. Upgrading first Validator to new version: c40c73ea3eed7889ae38aa8a963da6320487936e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7241.39 txn/s, latency: 3744.84 ms, (p50: 3700 ms, p70: 4400, p90: 5100 ms, p99: 5400 ms), latency samples: 136460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7360.61 txn/s, latency: 4352.38 ms, (p50: 4400 ms, p70: 4500, p90: 6300 ms, p99: 6400 ms), latency samples: 245900
3. Upgrading rest of first batch to new version: c40c73ea3eed7889ae38aa8a963da6320487936e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7582.57 txn/s, latency: 3748.72 ms, (p50: 4200 ms, p70: 4400, p90: 4500 ms, p99: 4700 ms), latency samples: 139940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6832.78 txn/s, latency: 4324.57 ms, (p50: 4500 ms, p70: 4500, p90: 4600 ms, p99: 6300 ms), latency samples: 260840
4. upgrading second batch to new version: c40c73ea3eed7889ae38aa8a963da6320487936e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11642.54 txn/s, latency: 2334.83 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 2900 ms), latency samples: 202860
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11620.60 txn/s, latency: 2705.08 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4400 ms), latency samples: 381000
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> c40c73ea3eed7889ae38aa8a963da6320487936e passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:build-performance-images build performance docker image variants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants