-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos in documentation files #15248
Conversation
⏱️ 30m total CI duration on this PR
|
@davidiw Hi! Apologies for the inconvenience. I just wanted to check if there’s anything I can improve in my pull request. Please feel free to ask any questions or let me know if any changes are needed to meet the project's merge requirements. I’m happy to make adjustments! |
Nope! Just was at Devcon last week, so missed this. Let's make it happen :) |
@davidiw Could you please tell me if I need to make any more changes before merging? |
This breaks the generation of docs for Move files, |
Crud, the linters didn't pick that up... Can you help push a new pr? |
@@ -12,7 +12,7 @@ The `--check` flag can be used to check if the code is formatted correctly. | |||
./scripts/rust_lint.sh | |||
``` | |||
|
|||
> **Note:** xclippy is an alias for `cargo clippy` with additional flags to enable more lints. | |||
> **Note:** clippy is an alias for `cargo clippy` with additional flags to enable more lints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually xclippy
https://github.com/aptos-labs/aptos-core/blob/main/.cargo/config.toml#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8dc501b
Good call, fixed
Description
This pull request addresses several spelling and grammatical issues across the codebase. These changes help improve code clarity and reduce the likelihood of confusion for contributors and users. Specifically, the following corrections were made:
"stablized" → "stabilized"
"xclippy" → "clippy"
"offerred" → "offered"
"respone" → "response"
"valdiator" → "validator"
These fixes were primarily applied in variable names, comments, and documentation.
No new dependencies were introduced as part of these changes.
How Has This Been Tested?
The changes do not affect functionality but improve code readability. As a result, no new tests were needed.
All existing unit and integration tests were run to ensure the correctness of the system.
Key Areas to Review
Which Components or Systems Does This Change Impact?
Checklist