Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define fungible asset, token, and unit in the glossary #8194

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

saharct
Copy link
Contributor

@saharct saharct commented May 15, 2023

Description

Let's generically define these terms to consider current and future ways of creating fungible assets. We can rephrase or add a bullet if more specificity is needed, but we should first work toward clarifying any confusion within the standards docs.

@saharct saharct added the documentation Improvements or additions to documentation label May 15, 2023
@saharct saharct requested review from lightmark, sausagee and lbmeiyi May 15, 2023 13:05
Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think another term is fungible token?

developer-docs-site/docs/reference/glossary.md Outdated Show resolved Hide resolved
@saharct
Copy link
Contributor Author

saharct commented May 15, 2023

I think another term is fungible token?

Yes, I'll add Fungible Token too. I initially wanted to mention tokens as a potential type of FA to avoid a separate definition, but it's worth defining Fungible Token separately.

@saharct saharct requested a review from davidiw May 16, 2023 01:43
@saharct saharct changed the title Add fungible asset and fungible unit to the glossary Define fungible asset, token, and unit in the glossary May 16, 2023

### Fungible Token

- A **fungible token** is a token that is interchangeable with other identical tokens (i.e., tokens that share the same `TokenId`). This means the tokens have the same `creator address`, `collection name`, `token name`, and `property version`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is different in token v2. fungible token should be a special type of fungible asset that the asset metadata is a token.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defined v1 first since the v2 docs are not public yet. I'm okay with updating the definition in this PR to include v1 and v2, then waiting until the other docs land before landing this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep it in general?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's define two bullets here.

@sionescu sionescu requested a review from a team as a code owner May 22, 2023 20:12
developer-docs-site/docs/reference/glossary.md Outdated Show resolved Hide resolved

### Fungible Token

- A **fungible token** is a token that is interchangeable with other identical tokens (i.e., tokens that share the same `TokenId`). This means the tokens have the same `creator address`, `collection name`, `token name`, and `property version`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's define two bullets here.

developer-docs-site/docs/reference/glossary.md Outdated Show resolved Hide resolved
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
@davidiw davidiw merged commit 23ea9c2 into main Jun 2, 2023
@davidiw davidiw deleted the saharct/glossary branch June 2, 2023 06:44
gedigi pushed a commit that referenced this pull request Jun 6, 2023
* Define fungible asset and unit in glossary.md

* Define fungible token

* Require permission check before running determine-docker-build-metadata

* Apply suggestions from code review

Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>

---------

Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com>
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
banool pushed a commit that referenced this pull request Jul 7, 2023
* Define fungible asset and unit in glossary.md

* Define fungible token

* Require permission check before running determine-docker-build-metadata

* Apply suggestions from code review

Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>

---------

Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com>
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants