-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define fungible asset, token, and unit in the glossary #8194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think another term is fungible token
?
Yes, I'll add |
|
||
### Fungible Token | ||
|
||
- A **fungible token** is a token that is interchangeable with other identical tokens (i.e., tokens that share the same `TokenId`). This means the tokens have the same `creator address`, `collection name`, `token name`, and `property version`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is different in token v2. fungible token should be a special type of fungible asset that the asset metadata is a token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defined v1 first since the v2 docs are not public yet. I'm okay with updating the definition in this PR to include v1 and v2, then waiting until the other docs land before landing this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep it in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's define two bullets here.
|
||
### Fungible Token | ||
|
||
- A **fungible token** is a token that is interchangeable with other identical tokens (i.e., tokens that share the same `TokenId`). This means the tokens have the same `creator address`, `collection name`, `token name`, and `property version`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's define two bullets here.
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
* Define fungible asset and unit in glossary.md * Define fungible token * Require permission check before running determine-docker-build-metadata * Apply suggestions from code review Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com> --------- Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com> Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
* Define fungible asset and unit in glossary.md * Define fungible token * Require permission check before running determine-docker-build-metadata * Apply suggestions from code review Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com> --------- Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com> Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
Description
Let's generically define these terms to consider current and future ways of creating fungible assets. We can rephrase or add a bullet if more specificity is needed, but we should first work toward clarifying any confusion within the standards docs.