Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm/forge] remove pyroscope #8264

Merged
merged 1 commit into from
May 18, 2023
Merged

[helm/forge] remove pyroscope #8264

merged 1 commit into from
May 18, 2023

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented May 18, 2023

Description

Pyroscope continuous profiler was previously set up for Forge, but never really worked. Removing for now, and we can choose whether or not to invest more time into getting it working. There exist other ways to profile

Test Plan

Forge CLI+wrapper unit tests, and Forge itself on the PR

@rustielin rustielin added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label May 18, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@rustielin rustielin marked this pull request as ready for review May 18, 2023 02:55
@rustielin rustielin requested a review from a team as a code owner May 18, 2023 02:55
@github-actions

This comment has been minimized.

@rustielin rustielin force-pushed the rustielin/remove-pyroscope branch from f2019c6 to e7be7b2 Compare May 18, 2023 03:20
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939

performance benchmark : 6268 TPS, 6303 ms latency, 17200 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10197 TPS, 3695 ms latency, 6100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939
compatibility::simple-validator-upgrade::single-validator-upgrade : 5793 TPS, 6934 ms latency, 9600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939
compatibility::simple-validator-upgrade::half-validator-upgrade : 5747 TPS, 6945 ms latency, 9300 ms p99 latency,no expired txns
4. upgrading second batch to new version: e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7745 TPS, 4881 ms latency, 8300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939 (PR)
Upgrade the nodes to version: e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939
framework_upgrade::framework-upgrade::full-framework-upgrade : 5810 TPS, 6782 ms latency, 10200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> e7be7b2bde60e9b1bd1dd1cc6551df8b61d0b939 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants