Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Smoke tests] add an env variable to save node logs locally #8445

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[Smoke tests] add an env variable to save node logs locally #8445

merged 1 commit into from
Jun 1, 2023

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented May 31, 2023 •
edited
Loading

Description

This makes it easier to inspect node logs after running a successful smoke test.

Example usage:

LOCAL_SWARM_SAVE_LOGS=1 cargo test --package smoke-test test_full_node_basic_flow -- --nocapture

The last logged line will have the location, e.g.,

Logs located at /var/folders/7h/r8yg843j0tl24vsc33ddl9s40000gn/T/.tmpHbbwHX

@bchocho bchocho changed the title [Smoke tests] add an env variable to make it easier to read node logs locally [Smoke tests] add an env variable to save node logs locally May 31, 2023
@bchocho bchocho marked this pull request as ready for review May 31, 2023 03:37
@bchocho bchocho requested a review from JoshLind May 31, 2023 03:37
@bchocho bchocho enabled auto-merge (squash) June 1, 2023 12:24
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10264 TPS, 3656 ms latency, 6100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 734fce5e36f93155ad30a8e3d34972cf18f1894a
compatibility::simple-validator-upgrade::single-validator-upgrade : 6142 TPS, 6366 ms latency, 8600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 734fce5e36f93155ad30a8e3d34972cf18f1894a
compatibility::simple-validator-upgrade::half-validator-upgrade : 5854 TPS, 6628 ms latency, 9500 ms p99 latency,no expired txns
4. upgrading second batch to new version: 734fce5e36f93155ad30a8e3d34972cf18f1894a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8786 TPS, 4426 ms latency, 8100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite land_blocking success on 734fce5e36f93155ad30a8e3d34972cf18f1894a

performance benchmark : 5735 TPS, 6951 ms latency, 27700 ms p99 latency,(!) expired 76 out of 2449080 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a (PR)
Upgrade the nodes to version: 734fce5e36f93155ad30a8e3d34972cf18f1894a
framework_upgrade::framework-upgrade::full-framework-upgrade : 5734 TPS, 6924 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 734fce5e36f93155ad30a8e3d34972cf18f1894a passed
Test Ok

@bchocho bchocho merged commit 875f553 into main Jun 1, 2023
@bchocho bchocho deleted the brian/save-local-swarm-logs branch June 1, 2023 13:07
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@bchocho @gedigi
Add env variable to save logs (#8445)
42a3a64 
### Description

This makes it easier to inspect node logs after running a successful smoke test.

Example usage:
```
LOCAL_SWARM_SAVE_LOGS=1 cargo test --package smoke-test test_full_node_basic_flow -- --nocapture
```

The last logged line will have the location, e.g.,
```
Logs located at /var/folders/7h/r8yg843j0tl24vsc33ddl9s40000gn/T/.tmpHbbwHX
```
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool pushed a commit that referenced this pull request Jul 7, 2023
@bchocho @banool
Add env variable to save logs (#8445)
db1c753 
### Description

This makes it easier to inspect node logs after running a successful smoke test.

Example usage:
```
LOCAL_SWARM_SAVE_LOGS=1 cargo test --package smoke-test test_full_node_basic_flow -- --nocapture
```

The last logged line will have the location, e.g.,
```
Logs located at /var/folders/7h/r8yg843j0tl24vsc33ddl9s40000gn/T/.tmpHbbwHX
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLind JoshLind JoshLind approved these changes

@msmouse msmouse msmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bchocho @msmouse @JoshLind