Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]update module file name recommendation #8463

Merged
merged 1 commit into from
Jun 2, 2023
Merged

[docs]update module file name recommendation #8463

merged 1 commit into from
Jun 2, 2023

Conversation

fgfm999
Copy link
Contributor

@fgfm999 fgfm999 commented Jun 1, 2023

Description

Update module file name recommendation.
Since we recommend to use lower snake case for module name, and keep module name and module file name to be same, the example should be option.move.

Test Plan

@fgfm999 fgfm999 requested a review from saharct as a code owner June 1, 2023 12:08
davidiw
davidiw approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finds

@davidiw davidiw merged commit 65d160b into aptos-labs:main Jun 2, 2023
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@fgfm999 @gedigi
[docs]update module file name recommendation (#8463)
bec8ed6
@fgfm999 fgfm999 deleted the fix-coding-conventions branch June 15, 2023 04:35
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool pushed a commit that referenced this pull request Jul 7, 2023
@fgfm999 @banool
[docs]update module file name recommendation (#8463)
9838544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw approved these changes

@saharct saharct Awaiting requested review from saharct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgfm999 @davidiw