Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python SDK] Fix linting #8467

Merged
merged 3 commits into from
Jun 1, 2023
Merged

[Python SDK] Fix linting #8467

merged 3 commits into from
Jun 1, 2023

Conversation

0xmigo
Copy link
Contributor

@0xmigo 0xmigo commented Jun 1, 2023 •
edited
Loading

Description

poetry run isort .
poetry run black .

Test Plan

@0xmigo 0xmigo changed the title [Python SDK] add new line to end of file [Python SDK] Fix linting Jun 1, 2023
banool
banool approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@banool banool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ty!

@0xmigo 0xmigo enabled auto-merge (squash) June 1, 2023 18:28
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 486f79af430f05df44ed289f75230b6708870633

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 486f79af430f05df44ed289f75230b6708870633 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10333 TPS, 3655 ms latency, 6000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 486f79af430f05df44ed289f75230b6708870633
compatibility::simple-validator-upgrade::single-validator-upgrade : 6084 TPS, 6559 ms latency, 8200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 486f79af430f05df44ed289f75230b6708870633
compatibility::simple-validator-upgrade::half-validator-upgrade : 6132 TPS, 6491 ms latency, 8500 ms p99 latency,no expired txns
4. upgrading second batch to new version: 486f79af430f05df44ed289f75230b6708870633
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8203 TPS, 4627 ms latency, 8900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 486f79af430f05df44ed289f75230b6708870633 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite land_blocking success on 486f79af430f05df44ed289f75230b6708870633

performance benchmark : 5562 TPS, 7094 ms latency, 27700 ms p99 latency,(!) expired 60 out of 2375380 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 486f79af430f05df44ed289f75230b6708870633

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 486f79af430f05df44ed289f75230b6708870633 (PR)
Upgrade the nodes to version: 486f79af430f05df44ed289f75230b6708870633
framework_upgrade::framework-upgrade::full-framework-upgrade : 6402 TPS, 6214 ms latency, 8700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 486f79af430f05df44ed289f75230b6708870633 passed
Test Ok

@0xmigo 0xmigo merged commit 41d03c4 into main Jun 1, 2023
@0xmigo 0xmigo deleted the jin/fix_newline_lint branch June 1, 2023 19:08
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@0xmigo @gedigi
[Python SDK] Fix linting (#8467)
8d3f88a 
* add newline to fix linting error

* remove newline

* poetry run isort, poetry run black
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool pushed a commit that referenced this pull request Jul 7, 2023
@0xmigo @banool
[Python SDK] Fix linting (#8467)
1dcb43e 
* add newline to fix linting error

* remove newline

* poetry run isort, poetry run black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

@banool banool banool approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@gregnazario gregnazario Awaiting requested review from gregnazario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmigo @banool @0xmaayan