[TS SDK] Add query to fetch all collections that an account has tokens for #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
It looks fine to me. Could you get @rtso or @bowenyang007 to review the query?
| @@ -235,6 +235,11 @@ describe("Indexer", () => { | |||
| expect(tokens.current_token_ownerships_v2).toHaveLength(2); | |||
| }); | |||
|
|
|||
| it("gets account current tokens from a specified token standrd", async () => { | |||
banool
approved these changes
Jun 6, 2023
| tokenStandard?: TokenStandard; | ||
| options?: PaginationArgs; | ||
| }, | ||
| ): Promise<GetCollectionsWithOwnedTokensQuery> { |
There was a problem hiding this comment.
The comment about what this returns and the return type here don't match, could you update that?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
…s for (#8498) * add query to get all collections that an account has tokens for * use token standard param in query condition * update changelog * address feedback
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
…s for (#8498) * add query to get all collections that an account has tokens for * use token standard param in query condition * update changelog * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add query to fetch all collections that an account has tokens for. supports v1 and/or v2 standards
Test Plan