Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] Add workflow to build release binaries #8504

Merged
merged 1 commit into from
Jun 3, 2023
Merged

[release] Add workflow to build release binaries #8504

merged 1 commit into from
Jun 3, 2023

Conversation

perryjrandall
Copy link
Contributor

@perryjrandall perryjrandall commented Jun 2, 2023 •
edited
Loading

This makes our builds available mirroring what we do for hotfix release

Test Plan:

Added a clause to run on PR, remove that before landing

https://github.com/aptos-labs/aptos-core/actions/runs/5159644124

@perryjrandall perryjrandall requested a review from a team as a code owner June 2, 2023 20:50
@perryjrandall perryjrandall force-pushed the perry-build-binaries branch from 0572cb5 to c75f1f2 Compare June 2, 2023 20:51
perryjrandall
perryjrandall commented Jun 2, 2023
View reviewed changes
.github/workflows/build-node-binaries.yaml Outdated
@@ -0,0 +1,45 @@
# This defines a workflow to build and release a new version of the aptos CLI.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changes pending for this but I want to see the job pass / fail first since it takes so damn long :P

@perryjrandall
[release] Add workflow to build release binaries
ec13053 
This makes our builds available mirroring what we do for hotfix release

Test Plan:

Added a clause to run on PR, remove that before landing
@perryjrandall perryjrandall force-pushed the perry-build-binaries branch from c75f1f2 to ec13053 Compare June 2, 2023 21:15
@perryjrandall perryjrandall enabled auto-merge (squash) June 2, 2023 23:39
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ec13053533b8a113422a793ffca6195951a649d5

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ec13053533b8a113422a793ffca6195951a649d5 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10325 TPS, 3658 ms latency, 5900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: ec13053533b8a113422a793ffca6195951a649d5
compatibility::simple-validator-upgrade::single-validator-upgrade : 5666 TPS, 7003 ms latency, 9900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: ec13053533b8a113422a793ffca6195951a649d5
compatibility::simple-validator-upgrade::half-validator-upgrade : 5818 TPS, 6623 ms latency, 8700 ms p99 latency,no expired txns
4. upgrading second batch to new version: ec13053533b8a113422a793ffca6195951a649d5
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8050 TPS, 4698 ms latency, 7400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ec13053533b8a113422a793ffca6195951a649d5 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

✅ Forge suite land_blocking success on ec13053533b8a113422a793ffca6195951a649d5

performance benchmark : 5858 TPS, 6758 ms latency, 22300 ms p99 latency,(!) expired 120 out of 2501580 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ec13053533b8a113422a793ffca6195951a649d5

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ec13053533b8a113422a793ffca6195951a649d5 (PR)
Upgrade the nodes to version: ec13053533b8a113422a793ffca6195951a649d5
framework_upgrade::framework-upgrade::full-framework-upgrade : 5745 TPS, 6924 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ec13053533b8a113422a793ffca6195951a649d5 passed
Test Ok

@perryjrandall perryjrandall merged commit b3e82b3 into main Jun 3, 2023
@perryjrandall perryjrandall deleted the perry-build-binaries branch June 3, 2023 00:15
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@perryjrandall @gedigi
[release] Add workflow to build release binaries (#8504)
0714f71 
This makes our builds available mirroring what we do for hotfix release

Test Plan:

Added a clause to run on PR, remove that before landing

https://github.com/aptos-labs/aptos-core/actions/runs/5159644124
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool pushed a commit that referenced this pull request Jul 7, 2023
@perryjrandall @banool
[release] Add workflow to build release binaries (#8504)
236ed1f 
This makes our builds available mirroring what we do for hotfix release

Test Plan:

Added a clause to run on PR, remove that before landing

https://github.com/aptos-labs/aptos-core/actions/runs/5159644124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sionescu sionescu sionescu approved these changes

@rustielin rustielin rustielin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perryjrandall @sionescu @rustielin