Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" #8514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedigi
pushed a commit
that referenced
this pull request
Jun 6, 2023
rustielin
added a commit
that referenced
this pull request
Jun 15, 2023
* Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
* Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…s-labs#8599) * Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (aptos-labs#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…s-labs#8599) * Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (aptos-labs#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
* Revert "Revert "[gha][docker] only push to GAR on PR; push to ECR on postcommit" (#8514)" This reverts commit c32e918. * [forge] find latest images based on cloud * [gha] make GCP the default target registry for docker build Co-authored-by: Balaji Arun <balaji@aptoslabs.com> * [gha/docker] make remote TARGET_REGISTRY backwards compatible * [testsuite] find docker images on GCP using crane --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8500
due to it breaking forge jobs