Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prover][Spec] Fix apply schema #8518

Merged
merged 5 commits into from
Jun 7, 2023
Merged

[Prover][Spec] Fix apply schema #8518

merged 5 commits into from
Jun 7, 2023

Conversation

rahxephon89
Copy link
Contributor

Description

This PR does the following two things in separate commits.

Test Plan

  1. aptos move prove in the framework folder
  2. add a new test case for the prover test

@rahxephon89 rahxephon89 marked this pull request as ready for review June 4, 2023 19:48
@rahxephon89 rahxephon89 requested review from wrwg and meng-xu-cs June 4, 2023 20:47
Copy link
Contributor

@junkil-park junkil-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rahxephon89 rahxephon89 enabled auto-merge (squash) June 6, 2023 22:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c452e0c2b59147774631770e1ae3beb4946e40f8

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c452e0c2b59147774631770e1ae3beb4946e40f8 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 9718 TPS, 3823 ms latency, 6000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: c452e0c2b59147774631770e1ae3beb4946e40f8
compatibility::simple-validator-upgrade::single-validator-upgrade : 5448 TPS, 7340 ms latency, 9800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: c452e0c2b59147774631770e1ae3beb4946e40f8
compatibility::simple-validator-upgrade::half-validator-upgrade : 5717 TPS, 6986 ms latency, 9100 ms p99 latency,no expired txns
4. upgrading second batch to new version: c452e0c2b59147774631770e1ae3beb4946e40f8
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7854 TPS, 4894 ms latency, 8500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c452e0c2b59147774631770e1ae3beb4946e40f8 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ Forge suite land_blocking success on c452e0c2b59147774631770e1ae3beb4946e40f8

performance benchmark : 5498 TPS, 7173 ms latency, 27800 ms p99 latency,(!) expired 249 out of 2348020 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c452e0c2b59147774631770e1ae3beb4946e40f8

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c452e0c2b59147774631770e1ae3beb4946e40f8 (PR)
Upgrade the nodes to version: c452e0c2b59147774631770e1ae3beb4946e40f8
framework_upgrade::framework-upgrade::full-framework-upgrade : 6026 TPS, 6624 ms latency, 10100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c452e0c2b59147774631770e1ae3beb4946e40f8 passed
Test Ok

@rahxephon89 rahxephon89 merged commit aaadc26 into main Jun 7, 2023
@rahxephon89 rahxephon89 deleted the prover-apply-bug branch June 7, 2023 01:57
banool pushed a commit that referenced this pull request Jul 7, 2023
* fix apply schema

* fix coin spec

* fix trigger condition for build jobs

---------

Co-authored-by: geekflyer <christian@aptoslabs.com>
gedigi pushed a commit that referenced this pull request Aug 2, 2023
* fix apply schema

* fix coin spec

* fix trigger condition for build jobs

---------

Co-authored-by: geekflyer <christian@aptoslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prover][Bug] requires in a schema are not correctly handled when using "apply ... to ..."
5 participants