Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Improve error message when compilation fails in aptos move publish #8556

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Jun 7, 2023

Description

Addresses #8554.

Test Plan

Before:

{
  "Error": "Unexpected error: Unable to resolve packages for package 'TokenObjects'"
}

After:

$ ~/a/core/target/debug/aptos move publish --named-addresses token_objects=0x1
Compiling, may take a little while to download git dependencies...
FETCHING GIT DEPENDENCY https://github.com/aptos-labs/aptos-core.git
{
  "Error": "Move compilation failed: Unable to resolve packages for package 'TokenObjects': While resolving dependency 'AptosFramework' in package 'TokenObjects': While processing dependency 'AptosFramework': Unable to find package manifest for 'AptosFramework' at \"/Users/dport/.move/https___github_com_aptos-labs_aptos-core_git_mainnet/aptos-move/framework/aptos-framework\""
}

@banool banool marked this pull request as ready for review June 7, 2023 09:30
@banool banool requested review from gregnazario and 0xmigo as code owners June 7, 2023 09:30
@banool banool enabled auto-merge (squash) June 7, 2023 09:30
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite land_blocking success on d9b99b2823ad8960ea24d446e031894f69147192

performance benchmark : 5678 TPS, 6957 ms latency, 26800 ms p99 latency,(!) expired 413 out of 2425280 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d9b99b2823ad8960ea24d446e031894f69147192

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d9b99b2823ad8960ea24d446e031894f69147192 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7354 TPS, 5755 ms latency, 29200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d9b99b2823ad8960ea24d446e031894f69147192
compatibility::simple-validator-upgrade::single-validator-upgrade : 6149 TPS, 6659 ms latency, 9400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d9b99b2823ad8960ea24d446e031894f69147192
compatibility::simple-validator-upgrade::half-validator-upgrade : 5354 TPS, 7599 ms latency, 10200 ms p99 latency,no expired txns
4. upgrading second batch to new version: d9b99b2823ad8960ea24d446e031894f69147192
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7294 TPS, 5635 ms latency, 17500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d9b99b2823ad8960ea24d446e031894f69147192 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> d9b99b2823ad8960ea24d446e031894f69147192

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> d9b99b2823ad8960ea24d446e031894f69147192 (PR)
Upgrade the nodes to version: d9b99b2823ad8960ea24d446e031894f69147192
framework_upgrade::framework-upgrade::full-framework-upgrade : 6120 TPS, 6559 ms latency, 12300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> d9b99b2823ad8960ea24d446e031894f69147192 passed
Test Ok

Copy link
Contributor

@0xmigo 0xmigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!

@banool banool merged commit d49a833 into main Jun 7, 2023
@banool banool deleted the banool/cli-publish-error branch June 7, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants