Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] update specs of voting.move #8557

Merged
merged 13 commits into from
Jun 15, 2023

Conversation

UIZorrot
Copy link
Contributor

@UIZorrot UIZorrot commented Jun 7, 2023

Description

This is a part of spec work for Aptos Framework from MoveBit. The changes are:

Completed all specs left as TODO in voting.

Test Plan

aptos move prove -f voting.move

Copy link
Contributor

@rahxephon89 rahxephon89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please fix the linter error in the PR.

@rahxephon89 rahxephon89 enabled auto-merge (squash) June 12, 2023 05:56
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@junkil-park junkil-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take care of the minor comments?

auto-merge was automatically disabled June 12, 2023 10:51

Head branch was pushed to by a user without write access

@junkil-park junkil-park enabled auto-merge (squash) June 13, 2023 00:12
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

auto-merge was automatically disabled June 15, 2023 05:45

Head branch was pushed to by a user without write access

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8808 txn/s, latency: 3673 ms, (p50: 3600 ms, p90: 5100 ms, p99: 5800 ms), latency samples: 308300
2. Upgrading first Validator to new version: 5c7f81443fb59781b5414f300e0c6cbbad168cf0
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4814 txn/s, latency: 6731 ms, (p50: 7400 ms, p90: 8500 ms, p99: 8800 ms), latency samples: 182940
3. Upgrading rest of first batch to new version: 5c7f81443fb59781b5414f300e0c6cbbad168cf0
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4893 txn/s, latency: 6408 ms, (p50: 6900 ms, p90: 7900 ms, p99: 9500 ms), latency samples: 190840
4. upgrading second batch to new version: 5c7f81443fb59781b5414f300e0c6cbbad168cf0
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6362 txn/s, latency: 5030 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8900 ms), latency samples: 229060
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 5c7f81443fb59781b5414f300e0c6cbbad168cf0

performance benchmark : committed: 5566 txn/s, submitted: 5567 txn/s, latency: 7120 ms, (p50: 6000 ms, p90: 9300 ms, p99: 26800 ms), latency samples: 2376953
Max round gap was 2 [limit 4] at version 2151335. Max no progress secs was 4.576684 [limit 10] at version 2151335.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0 (PR)
Upgrade the nodes to version: 5c7f81443fb59781b5414f300e0c6cbbad168cf0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4862 txn/s, latency: 6839 ms, (p50: 6700 ms, p90: 9900 ms, p99: 12000 ms), latency samples: 179920
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5c7f81443fb59781b5414f300e0c6cbbad168cf0 passed
Test Ok

@junkil-park junkil-park merged commit 695bbac into aptos-labs:main Jun 15, 2023
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
* init

* fix lint

* fix linter

* fix trimspace

* fix comment

* fix md
banool pushed a commit that referenced this pull request Jul 7, 2023
* init

* fix lint

* fix linter

* fix trimspace

* fix comment

* fix md
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* init

* fix lint

* fix linter

* fix trimspace

* fix comment

* fix md
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* init

* fix lint

* fix linter

* fix trimspace

* fix comment

* fix md
gedigi pushed a commit that referenced this pull request Aug 2, 2023
* init

* fix lint

* fix linter

* fix trimspace

* fix comment

* fix md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants