Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stake flow diagram #8571

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix stake flow diagram #8571

merged 1 commit into from
Jun 7, 2023

Conversation

xindingw
Copy link
Contributor

@xindingw xindingw commented Jun 7, 2023

Description

When add stake:

  • If validator is active or pending_inactive, coins become pending_active.
  • If validator is inactive or pending_active, coins become active.

Reference:

if (is_current_epoch_validator(pool_address)) {

Test Plan

@xindingw xindingw force-pushed the xinding/fix-stake-state-diagram branch 2 times, most recently from 8fa1665 to ba5f94f Compare June 7, 2023 18:28
@xindingw xindingw enabled auto-merge (squash) June 7, 2023 20:02
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 44866315de270a6671b1aa20c630c431a948e677

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 44866315de270a6671b1aa20c630c431a948e677 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 9972 TPS, 3757 ms latency, 6200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 44866315de270a6671b1aa20c630c431a948e677
compatibility::simple-validator-upgrade::single-validator-upgrade : 5940 TPS, 6810 ms latency, 9100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 44866315de270a6671b1aa20c630c431a948e677
compatibility::simple-validator-upgrade::half-validator-upgrade : 6173 TPS, 6268 ms latency, 8500 ms p99 latency,no expired txns
4. upgrading second batch to new version: 44866315de270a6671b1aa20c630c431a948e677
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8329 TPS, 4682 ms latency, 8000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 44866315de270a6671b1aa20c630c431a948e677 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite land_blocking success on 44866315de270a6671b1aa20c630c431a948e677

performance benchmark : 5754 TPS, 6878 ms latency, 27100 ms p99 latency,(!) expired 120 out of 2457200 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 44866315de270a6671b1aa20c630c431a948e677

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 44866315de270a6671b1aa20c630c431a948e677 (PR)
Upgrade the nodes to version: 44866315de270a6671b1aa20c630c431a948e677
framework_upgrade::framework-upgrade::full-framework-upgrade : 5773 TPS, 7013 ms latency, 14500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 44866315de270a6671b1aa20c630c431a948e677 passed
Test Ok

@xindingw xindingw merged commit 182e238 into main Jun 7, 2023
@xindingw xindingw deleted the xinding/fix-stake-state-diagram branch June 7, 2023 20:40
banool pushed a commit that referenced this pull request Jul 7, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants