Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF] Add default for GKE maintenance window #8585

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

sionescu
Copy link
Contributor

@sionescu sionescu commented Jun 8, 2023

Terraform will complain that the default is null.
The default maintenance window is Monday-Friday, between 7am and 11am Pacific time.

Terraform will complain that the default is null.
The default maintenance window is Monday-Friday, between 7am and 11am
Pacific time.
@sionescu sionescu requested a review from a team as a code owner June 8, 2023 02:12
@sionescu sionescu enabled auto-merge (squash) June 8, 2023 02:12
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5226e0f021d011e60ff54afaffdccf7192078529

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5226e0f021d011e60ff54afaffdccf7192078529 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8758 txn/s, latency: 3746 ms, (p50: 3700 ms, p90: 5200 ms, p99: 6000 ms), latency samples: 297780
2. Upgrading first Validator to new version: 5226e0f021d011e60ff54afaffdccf7192078529
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4505 txn/s, latency: 6906 ms, (p50: 7500 ms, p90: 8800 ms, p99: 9500 ms), latency samples: 171200
3. Upgrading rest of first batch to new version: 5226e0f021d011e60ff54afaffdccf7192078529
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4128 txn/s, latency: 7519 ms, (p50: 8600 ms, p90: 10200 ms, p99: 10700 ms), latency samples: 156880
4. upgrading second batch to new version: 5226e0f021d011e60ff54afaffdccf7192078529
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7183 txn/s, latency: 4631 ms, (p50: 4700 ms, p90: 6600 ms, p99: 8100 ms), latency samples: 244240
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5226e0f021d011e60ff54afaffdccf7192078529 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

✅ Forge suite land_blocking success on 5226e0f021d011e60ff54afaffdccf7192078529

performance benchmark : committed: 5503 txn/s, latency: 7214 ms, (p50: 5700 ms, p90: 9600 ms, p99: 28000 ms), latency samples: 2349860
Max round gap was 1 [limit 4] at version 353906. Max no progress secs was 3.860585 [limit 10] at version 2591836.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5226e0f021d011e60ff54afaffdccf7192078529

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5226e0f021d011e60ff54afaffdccf7192078529 (PR)
Upgrade the nodes to version: 5226e0f021d011e60ff54afaffdccf7192078529
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4773 txn/s, latency: 6903 ms, (p50: 7100 ms, p90: 9000 ms, p99: 10200 ms), latency samples: 171840
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 5226e0f021d011e60ff54afaffdccf7192078529 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants