Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge test for testing throughput on network purely tuned for throughput #8595

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

igor-aptos
Copy link
Contributor

Description

Test Plan

@@ -102,8 +102,8 @@ impl Default for ConsensusConfig {
max_sending_block_bytes: 600 * 1024, // 600 KB
max_sending_block_bytes_quorum_store_override: 5 * 1024 * 1024, // 5MB
max_receiving_block_txns: 10000,
max_receiving_block_txns_quorum_store_override: 2
* MAX_SENDING_BLOCK_TXNS_QUORUM_STORE_OVERRIDE,
max_receiving_block_txns_quorum_store_override: 10000.max(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchocho max_receiving_block_txns_quorum_store_override shouldn't be lower than max_receiving_block_txns, which it is currently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Will need to make these a part of the sanitizer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either leave a comment to that effect or throw error

@igor-aptos igor-aptos requested a review from bchocho June 8, 2023 23:07
@igor-aptos igor-aptos added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jun 8, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/realistic_env_load_sweep branch from 93810ef to b2d104b Compare June 9, 2023 00:00
@igor-aptos igor-aptos requested a review from a team as a code owner June 9, 2023 00:00
@igor-aptos igor-aptos force-pushed the igor/realistic_network_tuned_for_throughput_test branch from 6fd7fdd to eb7c4f9 Compare June 9, 2023 00:02
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/realistic_env_load_sweep branch 3 times, most recently from 65a5c6a to b491c97 Compare June 9, 2023 05:19
@igor-aptos igor-aptos force-pushed the igor/realistic_network_tuned_for_throughput_test branch from eb7c4f9 to 7a384d3 Compare June 9, 2023 05:19
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/realistic_network_tuned_for_throughput_test branch from 96021d4 to dd3b9cd Compare June 13, 2023 05:53
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/realistic_network_tuned_for_throughput_test branch from dd3b9cd to 71a915e Compare June 13, 2023 16:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71a915e846afeb928799d24958f883ca1acd1b70

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71a915e846afeb928799d24958f883ca1acd1b70 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8596 txn/s, latency: 3927 ms, (p50: 3900 ms, p90: 5800 ms, p99: 7100 ms), latency samples: 283680
2. Upgrading first Validator to new version: 71a915e846afeb928799d24958f883ca1acd1b70
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4468 txn/s, latency: 6972 ms, (p50: 7400 ms, p90: 9200 ms, p99: 9800 ms), latency samples: 174260
3. Upgrading rest of first batch to new version: 71a915e846afeb928799d24958f883ca1acd1b70
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4361 txn/s, latency: 7197 ms, (p50: 7600 ms, p90: 8900 ms, p99: 9400 ms), latency samples: 161380
4. upgrading second batch to new version: 71a915e846afeb928799d24958f883ca1acd1b70
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6603 txn/s, latency: 4974 ms, (p50: 4900 ms, p90: 6800 ms, p99: 8100 ms), latency samples: 231120
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71a915e846afeb928799d24958f883ca1acd1b70 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71a915e846afeb928799d24958f883ca1acd1b70

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71a915e846afeb928799d24958f883ca1acd1b70 (PR)
Upgrade the nodes to version: 71a915e846afeb928799d24958f883ca1acd1b70
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4152 txn/s, latency: 7398 ms, (p50: 6300 ms, p90: 11400 ms, p99: 22600 ms), latency samples: 170260
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71a915e846afeb928799d24958f883ca1acd1b70 passed
Test Ok

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 71a915e846afeb928799d24958f883ca1acd1b70

performance benchmark : committed: 5430 txn/s, latency: 7267 ms, (p50: 5700 ms, p90: 9400 ms, p99: 28100 ms), latency samples: 2318620
Max round gap was 1 [limit 4] at version 372974. Max no progress secs was 3.78978 [limit 10] at version 2599808.
Test Ok

@igor-aptos igor-aptos merged commit d9232c9 into main Jun 13, 2023
@igor-aptos igor-aptos deleted the igor/realistic_network_tuned_for_throughput_test branch June 13, 2023 19:06
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants