-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage][Sharding] Implement create_checkpoint for LedgerDb, and deprecate use_state_kv_db flag. #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grao1991
requested review from
msmouse,
lightmark,
JoshLind and
gregnazario
as code owners
June 9, 2023 18:40
grao1991
force-pushed
the
grao_checkpoint
branch
2 times, most recently
from
June 9, 2023 19:00
89062f3
to
1989380
Compare
igor-aptos
approved these changes
Jun 9, 2023
msmouse
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Fix the tests please.
msmouse
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Fix the tests please.
grao1991
force-pushed
the
grao_checkpoint
branch
2 times, most recently
from
June 12, 2023 21:23
54203e4
to
a10c543
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grao1991
force-pushed
the
grao_checkpoint
branch
from
June 12, 2023 22:59
a10c543
to
8dc7b6b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grao1991
force-pushed
the
grao_checkpoint
branch
from
June 13, 2023 04:34
8dc7b6b
to
32cea0f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
auto-merge was automatically disabled
June 13, 2023 08:15
Base branch was modified
…recate use_state_kv_db flag.
grao1991
force-pushed
the
grao_checkpoint
branch
from
June 13, 2023 18:35
32cea0f
to
a926dbb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
…recate use_state_kv_db flag. (#8602)
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
…recate use_state_kv_db flag. (#8602)
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…recate use_state_kv_db flag. (aptos-labs#8602)
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…recate use_state_kv_db flag. (aptos-labs#8602)
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
…recate use_state_kv_db flag. (#8602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan