Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage][Sharding] Implement create_checkpoint for LedgerDb, and deprecate use_state_kv_db flag. #8602

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Jun 9, 2023

Description

Test Plan

@grao1991 grao1991 force-pushed the grao_checkpoint branch 2 times, most recently from 89062f3 to 1989380 Compare June 9, 2023 19:00
wijesinghe1967

This comment was marked as abuse.

wijesinghe1967

This comment was marked as abuse.

@aptos-labs aptos-labs deleted a comment from wijesinghe1967 Jun 9, 2023
@aptos-labs aptos-labs deleted a comment from wijesinghe1967 Jun 9, 2023
Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Fix the tests please.

Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Fix the tests please.

@grao1991 grao1991 force-pushed the grao_checkpoint branch 2 times, most recently from 54203e4 to a10c543 Compare June 12, 2023 21:23
@grao1991 grao1991 enabled auto-merge (squash) June 12, 2023 21:23
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

auto-merge was automatically disabled June 13, 2023 08:15

Base branch was modified

@grao1991 grao1991 enabled auto-merge (squash) June 13, 2023 18:44
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a926dbb256d1076217014c5b6c474efcbf720787

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a926dbb256d1076217014c5b6c474efcbf720787 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 9205 txn/s, latency: 3606 ms, (p50: 3500 ms, p90: 5000 ms, p99: 6000 ms), latency samples: 313000
2. Upgrading first Validator to new version: a926dbb256d1076217014c5b6c474efcbf720787
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4716 txn/s, latency: 6671 ms, (p50: 7500 ms, p90: 8300 ms, p99: 8600 ms), latency samples: 179240
3. Upgrading rest of first batch to new version: a926dbb256d1076217014c5b6c474efcbf720787
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4350 txn/s, latency: 7275 ms, (p50: 7500 ms, p90: 10300 ms, p99: 11100 ms), latency samples: 174000
4. upgrading second batch to new version: a926dbb256d1076217014c5b6c474efcbf720787
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7100 txn/s, latency: 4744 ms, (p50: 4600 ms, p90: 7200 ms, p99: 9100 ms), latency samples: 241400
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a926dbb256d1076217014c5b6c474efcbf720787 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on a926dbb256d1076217014c5b6c474efcbf720787

performance benchmark : committed: 5773 txn/s, submitted: 5774 txn/s, latency: 6856 ms, (p50: 5800 ms, p90: 9100 ms, p99: 26800 ms), latency samples: 2465394
Max round gap was 1 [limit 4] at version 1250333. Max no progress secs was 4.3300962 [limit 10] at version 1403415.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> a926dbb256d1076217014c5b6c474efcbf720787

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> a926dbb256d1076217014c5b6c474efcbf720787 (PR)
Upgrade the nodes to version: a926dbb256d1076217014c5b6c474efcbf720787
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4760 txn/s, latency: 6832 ms, (p50: 6900 ms, p90: 9300 ms, p99: 11100 ms), latency samples: 176120
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> a926dbb256d1076217014c5b6c474efcbf720787 passed
Test Ok

@grao1991 grao1991 merged commit f8385b3 into main Jun 13, 2023
@grao1991 grao1991 deleted the grao_checkpoint branch June 13, 2023 19:23
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
banool pushed a commit that referenced this pull request Jul 7, 2023
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants