Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer grpc] update the tls part for data service. #8632

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Jun 12, 2023

Description

  • Add the tls support for data service: server now supports both tls and non-tls at different ports.
  • Update the latency monitoring for data service.
  • Update the cache size: only 1m versions as buffer before evicted.

Test Plan

locally tested; looks good overall.

image

@larry-aptos larry-aptos requested a review from saharct as a code owner June 12, 2023 23:20
@larry-aptos larry-aptos force-pushed the fix-the-metrics-and-add-tls branch from 58521ea to 811130e Compare June 12, 2023 23:21
@abbyxion abbyxion enabled auto-merge (squash) June 13, 2023 00:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@larry-aptos larry-aptos force-pushed the fix-the-metrics-and-add-tls branch from d358b36 to 5045849 Compare June 14, 2023 06:56
@larry-aptos larry-aptos force-pushed the fix-the-metrics-and-add-tls branch from 5045849 to 5890392 Compare June 14, 2023 06:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 58903921d8e574ca22cafdd02001430572ff886b

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 58903921d8e574ca22cafdd02001430572ff886b (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8727 txn/s, latency: 3796 ms, (p50: 3700 ms, p90: 5300 ms, p99: 6300 ms), latency samples: 296720
2. Upgrading first Validator to new version: 58903921d8e574ca22cafdd02001430572ff886b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4675 txn/s, latency: 6727 ms, (p50: 6900 ms, p90: 9000 ms, p99: 10200 ms), latency samples: 182360
3. Upgrading rest of first batch to new version: 58903921d8e574ca22cafdd02001430572ff886b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4504 txn/s, latency: 7106 ms, (p50: 7900 ms, p90: 8900 ms, p99: 9200 ms), latency samples: 166680
4. upgrading second batch to new version: 58903921d8e574ca22cafdd02001430572ff886b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6510 txn/s, latency: 4896 ms, (p50: 4700 ms, p90: 7300 ms, p99: 9200 ms), latency samples: 234360
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 58903921d8e574ca22cafdd02001430572ff886b passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 58903921d8e574ca22cafdd02001430572ff886b

performance benchmark : committed: 5662 txn/s, latency: 7005 ms, (p50: 5700 ms, p90: 10500 ms, p99: 23300 ms), latency samples: 2418055
Max round gap was 1 [limit 4] at version 778225. Max no progress secs was 3.372772 [limit 10] at version 1538699.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 58903921d8e574ca22cafdd02001430572ff886b

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 58903921d8e574ca22cafdd02001430572ff886b (PR)
Upgrade the nodes to version: 58903921d8e574ca22cafdd02001430572ff886b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4975 txn/s, latency: 6532 ms, (p50: 6900 ms, p90: 9500 ms, p99: 9900 ms), latency samples: 184100
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 58903921d8e574ca22cafdd02001430572ff886b passed
Test Ok

@abbyxion abbyxion merged commit ddf2463 into main Jun 14, 2023
@abbyxion abbyxion deleted the fix-the-metrics-and-add-tls branch June 14, 2023 07:42
banool pushed a commit that referenced this pull request Jul 7, 2023
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants