Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify that functions can return references under certain conditions #8644

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Specify that functions can return references under certain conditions #8644

merged 2 commits into from
Jun 15, 2023

Conversation

saharct
Copy link
Contributor

@saharct saharct commented Jun 13, 2023

Description

Added a note in the Move Book under functions.md#return-type

Test Plan

@saharct saharct requested review from davidiw, wrwg and movekevin June 13, 2023 21:26
@saharct saharct marked this pull request as ready for review June 13, 2023 21:27
@saharct saharct added the documentation Improvements or additions to documentation label Jun 13, 2023
@saharct saharct linked an issue Jun 13, 2023 that may be closed by this pull request
[Feature Request] Add clarification in the Move book that functions can return references #8175
Closed
@saharct saharct requested a review from gregnazario June 15, 2023 00:08
@saharct saharct enabled auto-merge (squash) June 15, 2023 00:25
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 9111 txn/s, latency: 3661 ms, (p50: 3700 ms, p90: 5100 ms, p99: 6000 ms), latency samples: 309780
2. Upgrading first Validator to new version: ecd0c5dea16b356354b069774e3b6a06d8bd7f09
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4748 txn/s, latency: 6673 ms, (p50: 7300 ms, p90: 8100 ms, p99: 8500 ms), latency samples: 175680
3. Upgrading rest of first batch to new version: ecd0c5dea16b356354b069774e3b6a06d8bd7f09
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4144 txn/s, latency: 7910 ms, (p50: 8500 ms, p90: 10100 ms, p99: 10500 ms), latency samples: 153340
4. upgrading second batch to new version: ecd0c5dea16b356354b069774e3b6a06d8bd7f09
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6374 txn/s, latency: 5152 ms, (p50: 5000 ms, p90: 8100 ms, p99: 10400 ms), latency samples: 223120
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on ecd0c5dea16b356354b069774e3b6a06d8bd7f09

performance benchmark : committed: 5591 txn/s, submitted: 5593 txn/s, expired: 2 txn/s, latency: 7065 ms, (p50: 6000 ms, p90: 10200 ms, p99: 19800 ms), latency samples: 2387439
Max round gap was 1 [limit 4] at version 112430. Max no progress secs was 3.276138 [limit 10] at version 1727016.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09 (PR)
Upgrade the nodes to version: ecd0c5dea16b356354b069774e3b6a06d8bd7f09
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4797 txn/s, latency: 6782 ms, (p50: 7200 ms, p90: 9000 ms, p99: 10200 ms), latency samples: 177500
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ecd0c5dea16b356354b069774e3b6a06d8bd7f09 passed
Test Ok

@saharct saharct merged commit e914ed2 into main Jun 15, 2023
@saharct saharct deleted the saharct/move-book-functions branch June 15, 2023 01:08
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
@saharct @vusirikala
Specify that functions can return references under certain conditions (…
408057c 
…#8644)

* Add note that functions can return references

* Mention that inline functions can return such references
banool pushed a commit that referenced this pull request Jul 7, 2023
@saharct @banool
Specify that functions can return references under certain conditions (…
7543c68 
…#8644)

* Add note that functions can return references

* Mention that inline functions can return such references
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
@saharct @xbtmatt
Specify that functions can return references under certain conditions (…
431abb0 
…aptos-labs#8644)

* Add note that functions can return references

* Mention that inline functions can return such references
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
@saharct @xbtmatt
Specify that functions can return references under certain conditions (…
f6c1570 
…aptos-labs#8644)

* Add note that functions can return references

* Mention that inline functions can return such references
gedigi pushed a commit that referenced this pull request Aug 2, 2023
@saharct @gedigi
Specify that functions can return references under certain conditions (…
8138c6d 
…#8644)

* Add note that functions can return references

* Mention that inline functions can return such references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movekevin movekevin movekevin approved these changes

@gregnazario gregnazario gregnazario approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@wrwg wrwg Awaiting requested review from wrwg

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add clarification in the Move book that functions can return references
3 participants
@saharct @gregnazario @movekevin