-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] Use spot VM for executor-performance #8677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibalajiarun
force-pushed
the
balaji/spot-runner
branch
from
June 15, 2023 01:11
bc5451b
to
1dc46b1
Compare
ibalajiarun
requested review from
danielxiangzl,
igor-aptos and
a team
and removed request for
a team
June 15, 2023 01:11
rustielin
approved these changes
Jun 15, 2023
danielxiangzl
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
* [GHA] Use spot VM for executor-performance * test * duplicate spot runner * point workflow to main
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
* [GHA] Use spot VM for executor-performance * test * duplicate spot runner * point workflow to main
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
* [GHA] Use spot VM for executor-performance * test * duplicate spot runner * point workflow to main
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
* [GHA] Use spot VM for executor-performance * test * duplicate spot runner * point workflow to main
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
* [GHA] Use spot VM for executor-performance * test * duplicate spot runner * point workflow to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR duplicates the executor-performance workflow to run on
spot-runner
GHA runners which are backed by spot VM pool. We will use this to assess the availability and performance of the spot VM pool and evaluate if we can expand its use.The duplicated workflow is not required check, so won't block merge on failure.
Test Plan
Tested it in this run: https://github.com/aptos-labs/aptos-core/actions/runs/5273676507