Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Use spot VM for executor-performance #8677

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Jun 15, 2023

Description

This PR duplicates the executor-performance workflow to run on spot-runner GHA runners which are backed by spot VM pool. We will use this to assess the availability and performance of the spot VM pool and evaluate if we can expand its use.

The duplicated workflow is not required check, so won't block merge on failure.

Test Plan

Tested it in this run: https://github.com/aptos-labs/aptos-core/actions/runs/5273676507

@ibalajiarun ibalajiarun marked this pull request as ready for review June 15, 2023 01:11
@ibalajiarun ibalajiarun requested a review from a team as a code owner June 15, 2023 01:11
@ibalajiarun ibalajiarun requested review from danielxiangzl, igor-aptos and a team and removed request for a team June 15, 2023 01:11
Copy link
Contributor

@danielxiangzl danielxiangzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@ibalajiarun ibalajiarun enabled auto-merge (squash) June 16, 2023 00:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8719 txn/s, latency: 3810 ms, (p50: 3800 ms, p90: 5100 ms, p99: 6200 ms), latency samples: 296460
2. Upgrading first Validator to new version: 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4492 txn/s, latency: 6964 ms, (p50: 7800 ms, p90: 8800 ms, p99: 9600 ms), latency samples: 175200
3. Upgrading rest of first batch to new version: 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4681 txn/s, latency: 6859 ms, (p50: 7200 ms, p90: 8500 ms, p99: 9000 ms), latency samples: 173220
4. upgrading second batch to new version: 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1099 txn/s, latency: 31154 ms, (p50: 39500 ms, p90: 40100 ms, p99: 40400 ms), latency samples: 49480
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc

performance benchmark : committed: 5625 txn/s, submitted: 5626 txn/s, latency: 7039 ms, (p50: 5400 ms, p90: 10800 ms, p99: 27400 ms), latency samples: 2401909
Max round gap was 1 [limit 4] at version 1289093. Max no progress secs was 4.758526 [limit 10] at version 1458672.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc (PR)
Upgrade the nodes to version: 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4273 txn/s, latency: 7109 ms, (p50: 7200 ms, p90: 9300 ms, p99: 14300 ms), latency samples: 170920
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2fcdf013bb88d18192dcc1fd8cd6ec25dd0013cc passed
Test Ok

@rustielin rustielin disabled auto-merge June 16, 2023 16:46
@rustielin rustielin merged commit 181a3fd into main Jun 16, 2023
@rustielin rustielin deleted the balaji/spot-runner branch June 16, 2023 16:47
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
* [GHA] Use spot VM for executor-performance

* test

* duplicate spot runner

* point workflow to main
banool pushed a commit that referenced this pull request Jul 7, 2023
* [GHA] Use spot VM for executor-performance

* test

* duplicate spot runner

* point workflow to main
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* [GHA] Use spot VM for executor-performance

* test

* duplicate spot runner

* point workflow to main
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* [GHA] Use spot VM for executor-performance

* test

* duplicate spot runner

* point workflow to main
gedigi pushed a commit that referenced this pull request Aug 2, 2023
* [GHA] Use spot VM for executor-performance

* test

* duplicate spot runner

* point workflow to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants