-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BlockSTM] Better naming for execution task #8694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielxiangzl
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Jun 15, 2023
zekun000
approved these changes
Jun 16, 2023
msmouse
approved these changes
Jun 16, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
[BlockSTM] Better naming for execution task
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
[BlockSTM] Better naming for execution task
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
[BlockSTM] Better naming for execution task
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
[BlockSTM] Better naming for execution task
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
[BlockSTM] Better naming for execution task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some trivial renaming for better clarity. Adding
ExecutionTaskType
to distinguish the actual execution task from the wake-up task.Previously the
ExecutionTask
in thescheduler
containsOption<DependencyCondvar>
to distinguish the actual execution task from the fake execution task that just wakes up the earlier pending execution task viaDependencyCondvar
.Test Plan
Existing tests.