Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlockSTM] Better naming for execution task #8694

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Conversation

danielxiangzl
Copy link
Contributor

@danielxiangzl danielxiangzl commented Jun 15, 2023

Description

This PR does some trivial renaming for better clarity. Adding ExecutionTaskType to distinguish the actual execution task from the wake-up task.
Previously the ExecutionTask in the scheduler contains Option<DependencyCondvar> to distinguish the actual execution task from the fake execution task that just wakes up the earlier pending execution task via DependencyCondvar.

Test Plan

Existing tests.

@danielxiangzl danielxiangzl added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jun 15, 2023
@danielxiangzl danielxiangzl marked this pull request as ready for review June 15, 2023 23:56
@danielxiangzl danielxiangzl enabled auto-merge (squash) June 16, 2023 00:05
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8885 txn/s, latency: 3788 ms, (p50: 3700 ms, p90: 5400 ms, p99: 6200 ms), latency samples: 302100
2. Upgrading first Validator to new version: ee23d70eb9947415b6285c27cee498eb5b7ad7fe
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4586 txn/s, latency: 7043 ms, (p50: 7100 ms, p90: 9900 ms, p99: 10600 ms), latency samples: 178860
3. Upgrading rest of first batch to new version: ee23d70eb9947415b6285c27cee498eb5b7ad7fe
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4390 txn/s, latency: 7347 ms, (p50: 8100 ms, p90: 8900 ms, p99: 9600 ms), latency samples: 166820
4. upgrading second batch to new version: ee23d70eb9947415b6285c27cee498eb5b7ad7fe
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6470 txn/s, latency: 5229 ms, (p50: 5100 ms, p90: 7800 ms, p99: 9600 ms), latency samples: 239420
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on ee23d70eb9947415b6285c27cee498eb5b7ad7fe

performance benchmark : committed: 5479 txn/s, latency: 7242 ms, (p50: 5700 ms, p90: 11400 ms, p99: 26800 ms), latency samples: 2339550
Max round gap was 2 [limit 4] at version 636632. Max no progress secs was 4.89393 [limit 10] at version 636632.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe (PR)
Upgrade the nodes to version: ee23d70eb9947415b6285c27cee498eb5b7ad7fe
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4492 txn/s, latency: 7078 ms, (p50: 7500 ms, p90: 10200 ms, p99: 13900 ms), latency samples: 170720
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ee23d70eb9947415b6285c27cee498eb5b7ad7fe passed
Test Ok

@danielxiangzl danielxiangzl merged commit 903c684 into main Jun 16, 2023
@danielxiangzl danielxiangzl deleted the daniel-rename branch June 16, 2023 00:48
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
[BlockSTM] Better naming for execution task
banool pushed a commit that referenced this pull request Jul 7, 2023
[BlockSTM] Better naming for execution task
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
[BlockSTM] Better naming for execution task
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
[BlockSTM] Better naming for execution task
gedigi pushed a commit that referenced this pull request Aug 2, 2023
[BlockSTM] Better naming for execution task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants