Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all_modules function to BuiltPackage #8862

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Add all_modules function to BuiltPackage #8862

merged 1 commit into from
Jul 2, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Jun 27, 2023

Description

Getting all modules in a package, including dependencies, is helpful for downstream tools I am building. For example, to generate types based on a package, you need to do it for all modules, not just the root modules.

Test Plan

CI.

@banool banool enabled auto-merge (squash) June 27, 2023 14:16
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9

Compatibility test results for aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9 (PR)
1. Check liveness of validators at old version: aptos-node-v1.4.4
compatibility::simple-validator-upgrade::liveness-check : committed: 6838 txn/s, latency: 4894 ms, (p50: 4600 ms, p90: 6800 ms, p99: 8600 ms), latency samples: 232520
2. Upgrading first Validator to new version: e8c3f60cecbe5523911711f5296eab591daab3d9
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4257 txn/s, latency: 7411 ms, (p50: 7200 ms, p90: 9600 ms, p99: 10100 ms), latency samples: 166060
3. Upgrading rest of first batch to new version: e8c3f60cecbe5523911711f5296eab591daab3d9
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4209 txn/s, latency: 7626 ms, (p50: 8400 ms, p90: 9500 ms, p99: 10300 ms), latency samples: 164180
4. upgrading second batch to new version: e8c3f60cecbe5523911711f5296eab591daab3d9
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5962 txn/s, latency: 5393 ms, (p50: 5600 ms, p90: 7200 ms, p99: 8500 ms), latency samples: 214660
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e8c3f60cecbe5523911711f5296eab591daab3d9

two traffics test: inner traffic : committed: 6048 txn/s, latency: 6441 ms, (p50: 6300 ms, p90: 7800 ms, p99: 11700 ms), latency samples: 2631220
two traffics test : committed: 100 txn/s, latency: 2484 ms, (p50: 2400 ms, p90: 2800 ms, p99: 6800 ms), latency samples: 1820
Max round gap was 1 [limit 4] at version 1016518. Max no progress secs was 3.918662 [limit 10] at version 1016518.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9

Compatibility test results for aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9 (PR)
Upgrade the nodes to version: e8c3f60cecbe5523911711f5296eab591daab3d9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2952 txn/s, latency: 7474 ms, (p50: 8000 ms, p90: 10200 ms, p99: 13400 ms), latency samples: 162400
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> e8c3f60cecbe5523911711f5296eab591daab3d9 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants