Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust][SDK] update rust sdk doc #9324

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[Rust][SDK] update rust sdk doc #9324

merged 2 commits into from
Jul 28, 2023

Conversation

0xmigo
Copy link
Contributor

@0xmigo 0xmigo commented Jul 26, 2023

Description

Test Plan

@0xmigo 0xmigo requested review from gregnazario, banool, 0xmaayan, xbtmatt and a team July 26, 2023 23:00
@0xmigo 0xmigo requested a review from saharct as a code owner July 26, 2023 23:00
@xbtmatt
Copy link
Contributor

xbtmatt commented Jul 27, 2023

How come we're having them apply the patch as opposed to us doing it directly to the SDK? Just trying to understand- not sure I do

@0xmigo
Copy link
Contributor Author

0xmigo commented Jul 27, 2023

How come we're having them apply the patch as opposed to us doing it directly to the SDK? Just trying to understand- not sure I do

@xbtmatt Good question! Greg and I was looking at the rust doc, and we found this - https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

Remember that [patch] is applicable transitively but can only be defined at the top level so we consumers of my-library have to repeat the [patch] section if necessary.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a

Compatibility test results for aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4414 txn/s, latency: 6764 ms, (p50: 6300 ms, p90: 9200 ms, p99: 18400 ms), latency samples: 176560
2. Upgrading first Validator to new version: 71c655a6680ed765c398e5e7d753b58571381d5a
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1786 txn/s, latency: 16342 ms, (p50: 18700 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92900
3. Upgrading rest of first batch to new version: 71c655a6680ed765c398e5e7d753b58571381d5a
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1850 txn/s, latency: 15676 ms, (p50: 18500 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92540
4. upgrading second batch to new version: 71c655a6680ed765c398e5e7d753b58571381d5a
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3296 txn/s, latency: 9716 ms, (p50: 9900 ms, p90: 13800 ms, p99: 14300 ms), latency samples: 141740
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 71c655a6680ed765c398e5e7d753b58571381d5a

two traffics test: inner traffic : committed: 6852 txn/s, latency: 5726 ms, (p50: 5400 ms, p90: 7200 ms, p99: 10800 ms), latency samples: 2960400
two traffics test : committed: 100 txn/s, latency: 3134 ms, (p50: 3100 ms, p90: 3700 ms, p99: 4500 ms), latency samples: 1880
Max round gap was 1 [limit 4] at version 1486085. Max no progress secs was 3.748802 [limit 10] at version 1486085.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a

Compatibility test results for aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a (PR)
Upgrade the nodes to version: 71c655a6680ed765c398e5e7d753b58571381d5a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4586 txn/s, latency: 7153 ms, (p50: 7700 ms, p90: 9900 ms, p99: 11500 ms), latency samples: 169700
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 71c655a6680ed765c398e5e7d753b58571381d5a passed
Test Ok

@gregnazario gregnazario merged commit 3908ec5 into main Jul 28, 2023
@gregnazario gregnazario deleted the jin/fix_rust_sdk_doc branch July 28, 2023 17:19
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants