Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SDK] Support fee payer transaction #9445

Merged
merged 2 commits into from
Aug 3, 2023
Merged

[TS SDK] Support fee payer transaction #9445

merged 2 commits into from
Aug 3, 2023

Conversation

0xmaayan
Copy link
Contributor

@0xmaayan 0xmaayan commented Aug 2, 2023

Description

Adds support for fee payer transaction with

  • a function to generate a fee payer raw transaction which returns a FeePayerRawTransaction
  • a function to sign a fee payer raw transaction which returns the signer authenticator
  • a function to submit the signed fee payer raw transaction

Test Plan

tests are passing

@xbtmatt
Copy link
Contributor

xbtmatt commented Aug 3, 2023

Woohoo fee payer! Looks good to me, tried it out, pretty nifty. just a small nit w wording

@0xmaayan 0xmaayan force-pushed the gas_fee_payer branch 2 times, most recently from fa17a43 to 2379618 Compare August 3, 2023 00:10
Copy link
Contributor

@junkil-park junkil-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I am wondering when this feature will be released?

Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are mostly around consistency, just wondering if we need private keys for AptosAccount

@gregnazario
Copy link
Contributor

Great! I am wondering when this feature will be released?

Soon!

@0xmaayan 0xmaayan enabled auto-merge (squash) August 3, 2023 20:26
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite realistic_env_max_load success on 8823c1bac0264cca38a9a39da613b926b9022605

two traffics test: inner traffic : committed: 7042 txn/s, latency: 5551 ms, (p50: 5400 ms, p90: 6600 ms, p99: 11100 ms), latency samples: 3049540
two traffics test : committed: 100 txn/s, latency: 3346 ms, (p50: 3200 ms, p90: 4200 ms, p99: 6200 ms), latency samples: 1700
Max round gap was 1 [limit 4] at version 14722. Max no progress secs was 4.107737 [limit 10] at version 1542645.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605

Compatibility test results for aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4920 txn/s, latency: 6686 ms, (p50: 6600 ms, p90: 10200 ms, p99: 13500 ms), latency samples: 177140
2. Upgrading first Validator to new version: 8823c1bac0264cca38a9a39da613b926b9022605
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1545 txn/s, latency: 15948 ms, (p50: 18700 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92740
3. Upgrading rest of first batch to new version: 8823c1bac0264cca38a9a39da613b926b9022605
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1790 txn/s, latency: 16282 ms, (p50: 18600 ms, p90: 22300 ms, p99: 22500 ms), latency samples: 93080
4. upgrading second batch to new version: 8823c1bac0264cca38a9a39da613b926b9022605
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2997 txn/s, latency: 10081 ms, (p50: 10000 ms, p90: 13600 ms, p99: 15400 ms), latency samples: 134880
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605

Compatibility test results for aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605 (PR)
Upgrade the nodes to version: 8823c1bac0264cca38a9a39da613b926b9022605
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4585 txn/s, latency: 7112 ms, (p50: 7200 ms, p90: 9600 ms, p99: 12400 ms), latency samples: 169660
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 8823c1bac0264cca38a9a39da613b926b9022605 passed
Test Ok

@0xmaayan 0xmaayan merged commit a56468a into main Aug 3, 2023
@0xmaayan 0xmaayan deleted the gas_fee_payer branch August 3, 2023 21:02
xbtmatt pushed a commit that referenced this pull request Aug 13, 2023
* support fee payer transaction

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants