Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-builder] Increase lockup before executing proposals #9550

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

perryjrandall
Copy link
Contributor

Increase the lockup before executing proposals

Currently the release flow started consistently failing because we need to increase the lockup

This ensures that the lockup is sufficient before executing transactions

Test Plan: not sure how to test other than by running against testnet???

Please advise

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we don't add the args? Also I don't see the args being passed in from another component -- is that done in another repo?

@perryjrandall
Copy link
Contributor Author

what if we don't add the args? Also I don't see the args being passed in from another component -- is that done in another repo?

In this flow those are not optional args

@perryjrandall perryjrandall force-pushed the perry-release-builder-increase-lockup branch from dd461f1 to 5ea6a1e Compare September 15, 2023 00:45
@perryjrandall perryjrandall force-pushed the perry-release-builder-increase-lockup branch from c710f51 to c229d3b Compare September 27, 2023 22:06
@perryjrandall perryjrandall added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 27, 2023
@perryjrandall perryjrandall force-pushed the perry-release-builder-increase-lockup branch from c229d3b to 067c2b4 Compare September 27, 2023 22:30
Increase the lockup before executing proposals

Currently the release flow started consistently failing because we need to increase the lockup

This ensures that the lockup is sufficient before executing transactions

Test Plan: not sure how to test other than by running against testnet???

Please advise
@perryjrandall perryjrandall force-pushed the perry-release-builder-increase-lockup branch from 067c2b4 to 611cabc Compare September 27, 2023 22:34
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 611cabc34f1634aa47715542bc499b8e152a81ce

Compatibility test results for aptos-node-v1.6.2 ==> 611cabc34f1634aa47715542bc499b8e152a81ce (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4143 txn/s, latency: 7584 ms, (p50: 7500 ms, p90: 10500 ms, p99: 14800 ms), latency samples: 174040
2. Upgrading first Validator to new version: 611cabc34f1634aa47715542bc499b8e152a81ce
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1857 txn/s, latency: 15770 ms, (p50: 18700 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92860
3. Upgrading rest of first batch to new version: 611cabc34f1634aa47715542bc499b8e152a81ce
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1262 txn/s, submitted: 1322 txn/s, expired: 60 txn/s, latency: 15396 ms, (p50: 17500 ms, p90: 22300 ms, p99: 22900 ms), latency samples: 82038
4. upgrading second batch to new version: 611cabc34f1634aa47715542bc499b8e152a81ce
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3235 txn/s, latency: 9355 ms, (p50: 9900 ms, p90: 12000 ms, p99: 12600 ms), latency samples: 135880
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 611cabc34f1634aa47715542bc499b8e152a81ce passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 611cabc34f1634aa47715542bc499b8e152a81ce

two traffics test: inner traffic : committed: 6515 txn/s, latency: 6020 ms, (p50: 5700 ms, p90: 7500 ms, p99: 12300 ms), latency samples: 2821300
two traffics test : committed: 100 txn/s, latency: 2494 ms, (p50: 2400 ms, p90: 2800 ms, p99: 5300 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.237, avg: 0.214", "QsPosToProposal: max: 0.158, avg: 0.143", "ConsensusProposalToOrdered: max: 0.618, avg: 0.571", "ConsensusOrderedToCommit: max: 0.496, avg: 0.476", "ConsensusProposalToCommit: max: 1.073, avg: 1.047"]
Max round gap was 1 [limit 4] at version 529892. Max no progress secs was 4.37804 [limit 10] at version 529892.
Test Ok

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

❌ Forge suite framework_upgrade failure on aptos-node-v1.5.1 ==> 611cabc34f1634aa47715542bc499b8e152a81ce

Forge test runner terminated:
Trailing Log Lines:
Compiling, may take a little while to download git dependencies...
INCLUDING DEPENDENCY AptosFramework
INCLUDING DEPENDENCY AptosStdlib
INCLUDING DEPENDENCY MoveStdlib
BUILDING execution_hash
error: unexpected argument '<elided secret for Ed25519PrivateKey>' found

Usage: --private-key [OPTIONS]

For more information, try '--help'.
Debugging output:
NAME                                   READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0               1/1     Running     0          6m51s
aptos-node-1-validator-0               1/1     Running     0          6m21s
aptos-node-2-validator-0               1/1     Running     0          6m1s
aptos-node-3-validator-0               1/1     Running     0          5m41s
genesis-aptos-genesis-eforge22-vtcp7   0/1     Completed   0          9m23s

@perryjrandall perryjrandall merged commit b125faf into main Sep 28, 2023
41 of 43 checks passed
@perryjrandall perryjrandall deleted the perry-release-builder-increase-lockup branch September 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants