-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-builder] Increase lockup before executing proposals #9550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we don't add the args? Also I don't see the args being passed in from another component -- is that done in another repo?
In this flow those are not optional args |
dd461f1
to
5ea6a1e
Compare
c710f51
to
c229d3b
Compare
c229d3b
to
067c2b4
Compare
Increase the lockup before executing proposals Currently the release flow started consistently failing because we need to increase the lockup This ensures that the lockup is sufficient before executing transactions Test Plan: not sure how to test other than by running against testnet??? Please advise
067c2b4
to
611cabc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
❌ Forge suite
|
Increase the lockup before executing proposals
Currently the release flow started consistently failing because we need to increase the lockup
This ensures that the lockup is sufficient before executing transactions
Test Plan: not sure how to test other than by running against testnet???
Please advise